From: Jens Axboe <axboe@fb.com>
To: Dave Jones <davej@codemonkey.org.uk>,
<torvalds@linuxfoundation.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [GIT PULL] Followup single fix for block IO core pull
Date: Fri, 17 Apr 2015 09:45:00 -0600 [thread overview]
Message-ID: <55312A7C.70602@fb.com> (raw)
In-Reply-To: <20150417154148.GA8885@codemonkey.org.uk>
On 04/17/2015 09:41 AM, Dave Jones wrote:
> On Fri, Apr 17, 2015 at 09:12:01AM -0600, Jens Axboe wrote:
> > Hi Linus,
> >
> > A commit in the previous pull request introduce a regression. So far
> > only observed on qemu-sparc64, but it's a general bug. Please pull this
> > single fix to rectify that, thanks.
>
> I hit the same bug on two x86 boxes, bare-metal.
> Reverting the commit Guenter pointed out made them boot again,
> so definitely not sparc/qemu specific in any way.
>
> I suspect the only reason more people didn't see it is that not
> everyone is running with the mq-by-default config option yet ?
It is puzzling. I ran it on several boxes, both multi queue and not, and
both single mq queues and multiple. But the code is clearly wrong. So
yeah, it's not sparc64 specific in any way. My initial thought was that
this was another issue related to sparse CPU ids, but that's not the
case. It's a plain bug, unfortunately.
--
Jens Axboe
next prev parent reply other threads:[~2015-04-17 15:45 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-17 15:12 [GIT PULL] Followup single fix for block IO core pull Jens Axboe
2015-04-17 15:41 ` Dave Jones
2015-04-17 15:45 ` Jens Axboe [this message]
2015-04-17 15:48 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55312A7C.70602@fb.com \
--to=axboe@fb.com \
--cc=davej@codemonkey.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=torvalds@linuxfoundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox