From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965354AbbDQQ0J (ORCPT ); Fri, 17 Apr 2015 12:26:09 -0400 Received: from pegase1.c-s.fr ([93.17.236.30]:44884 "EHLO mailhub1.si.c-s.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933360AbbDQQ0E (ORCPT ); Fri, 17 Apr 2015 12:26:04 -0400 Message-ID: <55313413.2050604@c-s.fr> Date: Fri, 17 Apr 2015 18:25:55 +0200 From: leroy christophe User-Agent: Mozilla/5.0 (Windows NT 5.1; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: David Laight , Kim Phillips , Herbert Xu , David S Miller CC: "linuxppc-dev@lists.ozlabs.org" , "linux-kernel@vger.kernel.org" , "linux-crypto@vger.kernel.org" Subject: Re: [PATCH v3 03/17] crypto: talitos - talitos_ptr renamed ptr for more lisibility References: <20150417142356.797BC1A242C@localhost.localdomain> <063D6719AE5E284EB5DD2968C1650D6D1CB21235@AcuExch.aculab.com> In-Reply-To: <063D6719AE5E284EB5DD2968C1650D6D1CB21235@AcuExch.aculab.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Le 17/04/2015 17:14, David Laight a écrit : > From: Christophe Leroy >> Linux CodyingStyle recommends to use short variables for local >> variables. ptr is just good enough for those 3 lines functions. >> It helps keep single lines shorter than 80 characters. > ... >> -static void to_talitos_ptr(struct talitos_ptr *talitos_ptr, dma_addr_t dma_addr) >> +static void to_talitos_ptr(struct talitos_ptr *ptr, dma_addr_t dma_addr) >> { >> - talitos_ptr->ptr = cpu_to_be32(lower_32_bits(dma_addr)); >> - talitos_ptr->eptr = upper_32_bits(dma_addr); >> + ptr->ptr = cpu_to_be32(lower_32_bits(dma_addr)); >> + ptr->eptr = upper_32_bits(dma_addr); >> } > ... > > Maybe, but 'ptr' isn't a good choice. > > Any suggestion ? Christophe