From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933802AbbDQQ4c (ORCPT ); Fri, 17 Apr 2015 12:56:32 -0400 Received: from mail-am1on0055.outbound.protection.outlook.com ([157.56.112.55]:14944 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S933186AbbDQQ43 (ORCPT ); Fri, 17 Apr 2015 12:56:29 -0400 Authentication-Results: lists.infradead.org; dkim=none (message not signed) header.d=none; Message-ID: <55313B31.6040803@ezchip.com> Date: Fri, 17 Apr 2015 12:56:17 -0400 From: Chris Metcalf User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Catalin Marinas CC: , , , , , "dingtianhong@huawei.com" , , , Will Deacon , "lizefan@huawei.com" , Bamvor Jian Zhang , , , , , , , , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH] tile: use si_int instead of si_ptr for compat_siginfo References: <1423563011-12377-1-git-send-email-bamvor.zhangjian@huawei.com> <20150210122718.GC32052@e104818-lin.cambridge.arm.com> <54DB3B60.4050100@huawei.com> <20150211154054.GD9058@e104818-lin.cambridge.arm.com> <54DDAF2B.2070707@huawei.com> <20150213104455.GA3508@e104818-lin.cambridge.arm.com> <54DE730D.3090100@ezchip.com> <20150214112220.GB10246@MBP.local> <54ECF309.3020509@ezchip.com> <201503161908.t2GJ8fs5021877@farm-0002.internal.tilera.com> <20150323120253.GA12757@e104818-lin.cambridge.arm.com> In-Reply-To: <20150323120253.GA12757@e104818-lin.cambridge.arm.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [12.216.194.146] X-ClientProxiedBy: BN3PR09CA0042.namprd09.prod.outlook.com (25.160.111.180) To AM2PR02MB0770.eurprd02.prod.outlook.com (25.163.146.155) X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:AM2PR02MB0770; X-Forefront-Antispam-Report: BMV:1;SFV:NSPM;SFS:(10009020)(6049001)(6009001)(24454002)(51704005)(41574002)(479174004)(377454003)(33656002)(122386002)(42186005)(93886004)(23746002)(92566002)(65956001)(110136001)(19580395003)(46102003)(65806001)(66066001)(47776003)(83506001)(50986999)(65816999)(54356999)(76176999)(87266999)(86362001)(87976001)(64126003)(2950100001)(77096005)(77156002)(99136001)(62966003)(36756003)(15975445007)(40100003)(4001350100001)(50466002)(7059030)(18886065003);DIR:OUT;SFP:1101;SCL:1;SRVR:AM2PR02MB0770;H:[10.7.0.41];FPR:;SPF:None;MLV:sfv;LANG:en; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5002010)(5005006);SRVR:AM2PR02MB0770;BCL:0;PCL:0;RULEID:;SRVR:AM2PR02MB0770; X-Forefront-PRVS: 0549E6FD50 X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 17 Apr 2015 16:56:24.9205 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: AM2PR02MB0770 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/23/2015 08:02 AM, Catalin Marinas wrote: >> @@ -121,8 +119,7 @@ int copy_siginfo_from_user32(siginfo_t *to, struct compat_siginfo __user *from) >> > >> > err |= __get_user(to->si_pid, &from->si_pid); >> > err |= __get_user(to->si_uid, &from->si_uid); >> >- err |= __get_user(ptr32, &from->si_ptr); >> >- to->si_ptr = compat_ptr(ptr32); >> >+ err |= __get_user(to->si_int, &from->si_int); > We have a memset(to, 0, sizeof(*to)) on arm64 in this function but I > can't see it on tile. Some members or even half of si_ptr would be left > uninitialised. In the end I added a memset() for the tile compat case like you suggest for arm64. Thanks! -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com