From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752489AbbJKTNi (ORCPT <rfc822;w@1wt.eu>);
	Sun, 11 Oct 2015 15:13:38 -0400
Received: from mout.kundenserver.de ([212.227.126.130]:57483 "EHLO
	mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1752413AbbJKTNf (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Sun, 11 Oct 2015 15:13:35 -0400
From: Arnd Bergmann <arnd@arndb.de>
To: Yaniv Gardi <ygardi@codeaurora.org>
Cc: James.Bottomley@hansenpartnership.com, linux-kernel@vger.kernel.org,
        linux-scsi@vger.kernel.org, linux-arm-msm@vger.kernel.org,
        santoshsy@gmail.com, linux-scsi-owner@vger.kernel.org,
        subhashj@codeaurora.org, gbroner@codeaurora.org, draviv@codeaurora.org,
        Noa Rubens <noag@codeaurora.org>,
        Raviv Shvili <rshvili@codeaurora.org>,
        Vinayak Holikatti <vinholikatti@gmail.com>,
        "James E.J. Bottomley" <JBottomley@odin.com>,
        "open list:ABI/API" <linux-api@vger.kernel.org>
Subject: Re: [PATCH v4] scsi: ufs: add ioctl interface for query request
Date: Sun, 11 Oct 2015 21:13:17 +0200
Message-ID: <5532251.sHP7i3bdrH@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1444562547-3100-1-git-send-email-ygardi@codeaurora.org>
References: <1444562547-3100-1-git-send-email-ygardi@codeaurora.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
X-Provags-ID: V03:K0:LT2nf/oM/PMQRl5AnKzPPjMBFHHztvSt4m0gguRJcBzRK091Z/x
 MyJuqRWxjPI9MhW8x8HCAKATnuVj5e93PVXmGX9pN5i2NClts2u29xuUxj15AQK7WWu8V0Z
 3m0q1YkQV/Sp2ufdewCSftI86noMx59MTJXgB2cUSKCrjwQp1YDLPiNHu9FxKOMjeUrmxNl
 Q0EHlQt91Uz93M21ikPjQ==
X-UI-Out-Filterresults: notjunk:1;V01:K0:yuiCfuo7wJE=:Ogk2jD2BoVMtwjdex4y9q8
 vFCwsRRCAwBtBiovsoFntZjh4+IXmOuqjfNHgD0RDLfv2Ob6JB8f8ZBb1SWiclP613hOeFp5b
 QNjjdbPZyHQWHDvcel5gHmw2Kn5jtEGN2JsZ+ucn98FVysK0GL5/nbZiOs5mLCB4wsfir3XZd
 GuH45UAoxDGmrDHkqFrTx9eZwGO6zfKVdo0rU/1DaTK8DvMSPhDNENFL5Jh514bEbN6eL2bu9
 guvm7QC+r1yZ6ztge3Ss6vCJYgWHS1cJBE2y22mKU/YPAAvlHXcwLYhr3w03/1R1c70cA/oK2
 aYTMuvwtXcsLYan5cJvtY8NRYOuoeZOzDt09rqh2E5nqzAVxJNQeR112CfkZg70NPh9n8oxl1
 xjtQByV4HWwqhXSqN3iQaKM/V4ZVzxJSEPxZdXAzx3z5x6wjzJBcTXTBZTCQHz7G1gRehGgQH
 n6Nk3zHeyyOm37fajbxWsGEzSLWL/CfNT+kAAgDkukJZuIeLymuGTbmMyJ96Tmq5Jzlbb8Bz9
 8kqVdfsWDYacIYwdVPAk0XZbwcy1iETdeIF4jZyywig1RR3lq7jxAyM14utfHmcLidTg1Df2a
 7xqAtv+DmqHIFipmcFRUXzBuLmmxALvE3RoOzDY50GtJD6ET/i8vB1VCt6zHJuvLEKI3yily4
 1/50WoM0zljArJk8dQ14SbVwAFCOPjoatTb/Ksutn8A2v5+dxpSqPC3pSEkg0hYhlQF3Chpr7
 So+ffmvkXYVqdsPP
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Sunday 11 October 2015 14:22:12 Yaniv Gardi wrote:
>   * @cookie: cookie data
> @@ -5106,6 +5308,10 @@ static struct scsi_host_template ufshcd_driver_template = {
>         .eh_device_reset_handler = ufshcd_eh_device_reset_handler,
>         .eh_host_reset_handler   = ufshcd_eh_host_reset_handler,
>         .eh_timed_out           = ufshcd_eh_timed_out,
> +       .ioctl                  = ufshcd_ioctl,
> +#ifdef CONFIG_COMPAT
> +       .compat_ioctl           = ufshcd_ioctl,
> +#endif
>         .this_id                = -1,
>         .sg_tablesize           = SG_ALL,
>         .cmd_per_lun            = UFSHCD_CMD_PER_LUN,
> 

I think I commented before that the #ifdef here is not needed and should
just be removed. Otherwise it looks ok to me now.

	Arnd