From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752775AbbDUIhn (ORCPT ); Tue, 21 Apr 2015 04:37:43 -0400 Received: from mailout4.w1.samsung.com ([210.118.77.14]:52531 "EHLO mailout4.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750937AbbDUIhj (ORCPT ); Tue, 21 Apr 2015 04:37:39 -0400 X-AuditID: cbfec7f5-f794b6d000001495-ef-55360c518148 Message-id: <55360C44.4020107@samsung.com> Date: Tue, 21 Apr 2015 10:37:24 +0200 From: Sylwester Nawrocki User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-version: 1.0 To: Chanwoo Choi Cc: mturquette@linaro.org, sboyd@codeaurora.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] clk: Show clock rate and error value when fail to set clock rate References: <1429528131-9075-1-git-send-email-cw00.choi@samsung.com> In-reply-to: <1429528131-9075-1-git-send-email-cw00.choi@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrMLMWRmVeSWpSXmKPExsVy+t/xy7qBPGahBt9es1hc//Kc1eLyrjls Fk8nXGSz+HGmm8WBxeNyXy+Tx51re9g8+rasYvT4vEkugCWKyyYlNSezLLVI3y6BK2NR/2u2 gi98FVv+dbM2MF7j7mLk5JAQMJH48eEUM4QtJnHh3no2EFtIYCmjRPt9Jgj7OaPEtTUuIDav gJbEhA/XGEFsFgFViemLF4L1sgkYSvQe7QOKc3CICkRI3L7MCVEuKPFj8j0WEFtEQENi5t8r YK3MAr4SHdO/gbUKC0RJ/Jm4EmqVi8TvfcvBajgFXCXuzXnCDjKSWUBP4v5FLYhWeYnNa94y T2AUmIVkwyyEqllIqhYwMq9iFE0tTS4oTkrPNdIrTswtLs1L10vOz93ECAnarzsYlx6zOsQo wMGoxMMrscI0VIg1say4MvcQowQHs5II77WpQCHelMTKqtSi/Pii0pzU4kOM0hwsSuK8M3e9 DxESSE8sSc1OTS1ILYLJMnFwSjUwXi7pVL6eOUErwbXHVOpkq+IaLy9W91hmkQcLPjcWl+/d YTxlU/2Bk9ofX3TMTtGfaxOX8L57na/kghM75A7P6rvqflzx/8eKK9WzZvu1TOh4nT7xvvkG lUsMHyzOSco+OcH35elDtdmJB2P29V9a4d/0LHGKnlfULdmbvXn3ZPdskZi8pisnQImlOCPR UIu5qDgRAETjdwtWAgAA Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chanwoo, On 20/04/15 13:08, Chanwoo Choi wrote: > This patch shows the current clock rate nad error value when clk_set_rate() > fail to set the clock rate because log messgae means only the clock rate. > > Cc: Mike Turquette > Cc: Stephen Boyd > Cc: Sylwester Nawrocki > Signed-off-by: Chanwoo Choi > --- > Changes from v1: > - Add error value of clk-set_rate() with current clock rate > > drivers/clk/clk-conf.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/drivers/clk/clk-conf.c b/drivers/clk/clk-conf.c > index aad4796..2b6375f 100644 > --- a/drivers/clk/clk-conf.c > +++ b/drivers/clk/clk-conf.c > @@ -107,8 +107,9 @@ static int __set_clk_rates(struct device_node *node, bool clk_supplier) > > rc = clk_set_rate(clk, rate); > if (rc < 0) > - pr_err("clk: couldn't set %s clock rate: %d\n", > - __clk_get_name(clk), rc); > + pr_err("clk: couldn't set %s rate to %ld (%d)\n", > + __clk_get_name(clk), clk_get_rate(clk), > + rc); Apologies for my previous misleading comment, with this patch you log current clock rate as the rate which was attempted to be set. And these two will likely be different when clk_set_rate() failed. So it should rather be: pr_err("clk: couldn't set %s clk rate to %ld (%d)\n", __clk_get_name(clk), rate, rc); If you really need to log current rate, then it could be changed to: pr_err("clk: couldn't set %s clk rate to %ld (%d), current rate: %ld\n", __clk_get_name(clk), rate, rc, clk_get_rate(clk)); But I doubt we need to log all these parameters. The clock rate changes could be logged with the ftrace functionality added recently to the clk core. > clk_put(clk); > } > index++; -- Regards, Sylwester