From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752112AbbDUJOw (ORCPT ); Tue, 21 Apr 2015 05:14:52 -0400 Received: from smtp121.iad3a.emailsrvr.com ([173.203.187.121]:51384 "EHLO smtp121.iad3a.emailsrvr.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750775AbbDUJOu (ORCPT ); Tue, 21 Apr 2015 05:14:50 -0400 X-Sender-Id: abbotti@mev.co.uk Message-ID: <55361506.6000809@mev.co.uk> Date: Tue, 21 Apr 2015 10:14:46 +0100 From: Ian Abbott User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Icedove/31.6.0 MIME-Version: 1.0 To: Greg KH , Gbenga Adalumo CC: devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] Staging: comedi: fix coding style errors in daqboard2000.c References: <1429498771-21185-1-git-send-email-gbengadev@gmail.com> <20150420144347.GB7261@kroah.com> <20150421075005.GB10367@kroah.com> In-Reply-To: <20150421075005.GB10367@kroah.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 21/04/15 08:50, Greg KH wrote: > On Mon, Apr 20, 2015 at 07:57:31PM -0700, Gbenga Adalumo wrote: >> The patch fixes a trailing whitespace and code indenting coding style >> errors as reported by checkpatch.pl tool. >> Details of the lines where the fixed errors were reported are as follows: >> >> drivers/staging/comedi/drivers/daqboard2000.c:43: ERROR: trailing whitespace >> drivers/staging/comedi/drivers/daqboard2000.c:46: ERROR: code indent >> should use tabs where possible > > > > You don't have to list all of the individual errors, and not in a > line-wrapped way either. > > It looks like you are fixing different types of errors, so please > provide different patches to do them. Each patch should just do one > thing. All these "errors" occur in a single block comment. It would be preferable if that block comment were reformatted to use the usual block-comment style: /* * blah * blah */ This has already been done for some comedi drivers. Thanks, Ian A. -- -=( Ian Abbott @ MEV Ltd. E-mail: )=- -=( Web: http://www.mev.co.uk/ )=-