From: Sasha Levin <sasha.levin@oracle.com>
To: eunb.song@samsung.com
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] tools/liblockdep: Fix compilation error.
Date: Tue, 21 Apr 2015 08:20:53 -0400 [thread overview]
Message-ID: <553640A5.6020103@oracle.com> (raw)
In-Reply-To: <1442710772.114981429599600317.JavaMail.weblogic@epmlwas04c>
On 04/21/2015 03:00 AM, Eunbong Song wrote:
> diff --git a/tools/lib/lockdep/lockdep.c b/tools/lib/lockdep/lockdep.c
> index f42b7e9..f83a988 100644
> --- a/tools/lib/lockdep/lockdep.c
> +++ b/tools/lib/lockdep/lockdep.c
> @@ -1,2 +1,8 @@
> #include <linux/lockdep.h>
> +
> +#ifdef list_for_each_entry_rcu
> +#undef list_for_each_entry_rcu
> +#endif
> +#define list_for_each_entry_rcu(pos, head, member) list_for_each_entry(pos, head, member)
> +
> #include "../../../kernel/locking/lockdep.c"
I'd rather have it pull include/linux/rculist.h and "fix" it up for userspace like we did for the
rest of the headers rather than start adding exceptions in the main program code.
Thanks,
Sasha
prev parent reply other threads:[~2015-04-21 12:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-21 7:00 [PATCH] tools/liblockdep: Fix compilation error Eunbong Song
2015-04-21 12:20 ` Sasha Levin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553640A5.6020103@oracle.com \
--to=sasha.levin@oracle.com \
--cc=eunb.song@samsung.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox