From: Dave Hansen <dave.hansen@intel.com>
To: Thomas Gleixner <tglx@linutronix.de>, Fenghua Yu <fenghua.yu@intel.com>
Cc: "H. Peter Anvin" <hpa@linux.intel.com>,
Ingo Molnar <mingo@kernel.org>,
Asit K Mallick <asit.k.mallick@intel.com>,
Glenn Williamson <glenn.p.williamson@intel.com>,
linux-kernel <linux-kernel@vger.kernel.org>, x86 <x86@kernel.org>
Subject: Re: [PATCH Bugfix 1/4] x86/xsave.c: Fix xstate offsets and sizes enumeration
Date: Tue, 21 Apr 2015 07:28:29 -0700 [thread overview]
Message-ID: <55365E8D.1020406@intel.com> (raw)
In-Reply-To: <alpine.DEB.2.11.1504211101200.13914@nanos>
On 04/21/2015 02:16 AM, Thomas Gleixner wrote:
> On Sat, 18 Apr 2015, Fenghua Yu wrote:
>> From: Fenghua Yu <fenghua.yu@intel.com>
>> When enumerating xstate offsets and sizes from cpuid (eax=0x0d, ecx>=2),
>> it's possible that state m is not implemented while state n (n>m)
>> is implemented. So enumeration shouldn't stop at state m.
>>
>> There is no platform configured like above yet. But this could be a problem
>> in the future.
>
> So this is for future hardware. Why are you claiming this is a BUGFIX?
That was probably phrased badly. I don't know of any platforms out
there in the wild where this will be an issue. So we don't expect this
to impact any end users.
But, I'm not an end user. This bug is impacting me today. I'd like to
see it fixed as widely as possible so that end users have little chance
of running in to it in the future.
prev parent reply other threads:[~2015-04-21 14:28 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-18 20:12 [PATCH Bugfix 1/4] x86/xsave.c: Fix xstate offsets and sizes enumeration Fenghua Yu
2015-04-18 20:12 ` [PATCH Bugfix 2/4] x86/xsaves: Define and use user_xstate_size for xstate size in signal context Fenghua Yu
2015-04-18 20:12 ` [PATCH Bugfix 3/4] x86/xsaves: Rename xstate_size to kernel_xstate_size to explicitely distinguish xstate size in kernel from user space Fenghua Yu
2015-04-18 20:12 ` [PATCH Bugfix 4/4] x86/xsave: Don't add new states in xsave_struct Fenghua Yu
2015-04-21 9:16 ` [PATCH Bugfix 1/4] x86/xsave.c: Fix xstate offsets and sizes enumeration Thomas Gleixner
2015-04-21 12:54 ` Yu, Fenghua
2015-04-21 14:28 ` Thomas Gleixner
2015-04-21 14:28 ` Dave Hansen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55365E8D.1020406@intel.com \
--to=dave.hansen@intel.com \
--cc=asit.k.mallick@intel.com \
--cc=fenghua.yu@intel.com \
--cc=glenn.p.williamson@intel.com \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox