From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932942AbbDVG1v (ORCPT ); Wed, 22 Apr 2015 02:27:51 -0400 Received: from szxga01-in.huawei.com ([58.251.152.64]:28972 "EHLO szxga01-in.huawei.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932812AbbDVG1r (ORCPT ); Wed, 22 Apr 2015 02:27:47 -0400 Message-ID: <55373F4D.6060901@huawei.com> Date: Wed, 22 Apr 2015 14:27:25 +0800 From: Xishi Qiu User-Agent: Mozilla/5.0 (Windows NT 6.1; rv:12.0) Gecko/20120428 Thunderbird/12.0.1 MIME-Version: 1.0 To: Xishi Qiu CC: Andrew Morton , Yasuaki Ishimatsu , Kamezawa Hiroyuki , , Tang Chen , Gu Zheng , Xiexiuqi , Mel Gorman , David Rientjes , Linux MM , LKML , Tejun Heo Subject: Re: [PATCH 2/2 V3] memory-hotplug: remove reset_node_managed_pages() and reset_node_managed_pages() in hotadd_new_pgdat() References: <55362349.3090406@huawei.com> In-Reply-To: <55362349.3090406@huawei.com> Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.177.25.179] X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org add CC: Tejun Heo On 2015/4/21 18:15, Xishi Qiu wrote: > After hotadd_new_pgdat()->free_area_init_node(), pgdat's spanned/present are 0, > and zone's spanned/present/managed are 0, so remove reset_node_managed_pages() > and reset_node_managed_pages(). > > Signed-off-by: Xishi Qiu > --- > mm/memory_hotplug.c | 25 ------------------------- > 1 files changed, 0 insertions(+), 25 deletions(-) > > diff --git a/mm/memory_hotplug.c b/mm/memory_hotplug.c > index 49d7c07..ac6462f 100644 > --- a/mm/memory_hotplug.c > +++ b/mm/memory_hotplug.c > @@ -1064,16 +1064,6 @@ int __ref online_pages(unsigned long pfn, unsigned long nr_pages, int online_typ > } > #endif /* CONFIG_MEMORY_HOTPLUG_SPARSE */ > > -static void reset_node_present_pages(pg_data_t *pgdat) > -{ > - struct zone *z; > - > - for (z = pgdat->node_zones; z < pgdat->node_zones + MAX_NR_ZONES; z++) > - z->present_pages = 0; > - > - pgdat->node_present_pages = 0; > -} > - > /* we are OK calling __meminit stuff here - we have CONFIG_MEMORY_HOTPLUG */ > static pg_data_t __ref *hotadd_new_pgdat(int nid, u64 start) > { > @@ -1108,21 +1098,6 @@ static pg_data_t __ref *hotadd_new_pgdat(int nid, u64 start) > build_all_zonelists(pgdat, NULL); > mutex_unlock(&zonelists_mutex); > > - /* > - * zone->managed_pages is set to an approximate value in > - * free_area_init_core(), which will cause > - * /sys/device/system/node/nodeX/meminfo has wrong data. > - * So reset it to 0 before any memory is onlined. > - */ > - reset_node_managed_pages(pgdat); > - > - /* > - * When memory is hot-added, all the memory is in offline state. So > - * clear all zones' present_pages because they will be updated in > - * online_pages() and offline_pages(). > - */ > - reset_node_present_pages(pgdat); > - > return pgdat; > } >