From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966029AbbDVK2C (ORCPT ); Wed, 22 Apr 2015 06:28:02 -0400 Received: from mail-wi0-f175.google.com ([209.85.212.175]:36281 "EHLO mail-wi0-f175.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752403AbbDVK2A (ORCPT ); Wed, 22 Apr 2015 06:28:00 -0400 Message-ID: <553777AB.7080909@redhat.com> Date: Wed, 22 Apr 2015 12:27:55 +0200 From: Paolo Bonzini User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-Version: 1.0 To: =?UTF-8?B?UmFkaW0gS3LEjW3DocWZ?= CC: linux-kernel@vger.kernel.org, kvm@vger.kernel.org Subject: Re: [PATCH] KVM: x86: tweak types of fields in kvm_lapic_irq References: <1429635686-82328-1-git-send-email-pbonzini@redhat.com> <20150422093542.GA30285@potion.brq.redhat.com> In-Reply-To: <20150422093542.GA30285@potion.brq.redhat.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 22/04/2015 11:35, Radim Krčmář wrote: > > Change the level field to bool, since we assign 1 sometimes, but > > just mask icr_low with APIC_INT_ASSERT in apic_send_-ipi. > > Would be more consistent to change that assignment instead ... > If we dropped the idea that struct kvm_lapic_irq fields can be bitORed > to get the ICR, we could also easily change trig_mode/dest_mode to bool > level_trig/logical_dest. (I can do a followup patch.) Right, I thought of both. However, level is something that has an obviously understandable meaning as a bool, while trig_mode/dest_mode as you said have to be renamed as well. You're right on the u8 type for vector, too. But I probably will end up not committing this patch at all... Paolo