From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S934344AbbDVQCV (ORCPT ); Wed, 22 Apr 2015 12:02:21 -0400 Received: from www.sr71.net ([198.145.64.142]:47789 "EHLO blackbird.sr71.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933916AbbDVQCU (ORCPT ); Wed, 22 Apr 2015 12:02:20 -0400 Message-ID: <5537C609.7080608@sr71.net> Date: Wed, 22 Apr 2015 09:02:17 -0700 From: Dave Hansen User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Thomas Gleixner CC: Borislav Petkov , Oleg Nesterov , linux-kernel@vger.kernel.org, x86@kernel.org, dave.hansen@linux.intel.com, riel@redhat.com, sbsiddha@gmail.com, luto@amacapital.net, mingo@redhat.com, hpa@zytor.com, fenghua.yu@intel.com Subject: Re: [PATCH 01/16] x86, fpu: wrap get_xsave_addr() to make it safer References: <20150401004623.894DF37A@viggo.jf.intel.com> <20150401004624.49096AD0@viggo.jf.intel.com> <20150422104047.GA6897@pd.tnic> <20150422131618.GA16785@redhat.com> <20150422133146.GE6897@pd.tnic> <5537B6AD.6070507@sr71.net> In-Reply-To: Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/22/2015 08:17 AM, Thomas Gleixner wrote: > On Wed, 22 Apr 2015, Dave Hansen wrote: >> On 04/22/2015 06:31 AM, Borislav Petkov wrote: >>> I read tsk_get_xsave_field(@tsk, ) as give me the xsave field of @tsk >>> but doing used_math() we're querying current and I'm not sure >>> >>> tsk == current >>> >>> in all the call sites of tsk_get_xsave_field(). >> >> There aren't that many call sites. :) >> >> But, yeah, tsk==current for all of them at the moment. > > Is there a reason to have the task argument at all if thats only > intended for current? No, there is no good reason. I'll rework it and resend the set.