From: Henrik Rydberg <rydberg@bitmath.org>
To: Benjamin Tissoires <benjamin.tissoires@redhat.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Peter Hutterer <peter.hutterer@who-t.net>
Cc: Jiri Kosina <jkosina@suse.cz>,
"linux-input@vger.kernel.org" <linux-input@vger.kernel.org>,
lkml <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key
Date: Thu, 23 Apr 2015 20:52:27 +0200 [thread overview]
Message-ID: <55393F6B.8050904@bitmath.org> (raw)
In-Reply-To: <20150423183827.GA10937@mail.corp.redhat.com>
> My guess is that none of these drivers are
> able to handle a silent closing of a slot and the easiest solution might
> be to simply change the documentation if in fact nobody uses the
> compressed notation (which removes just one ABS_SLOT event within the
> frame, so not sure we can call it compressed BTW).
No, this is a very bad idea. As is obvious from the patch and the problem, there
are cases that the typical add/remove interface cannot handle, without either
adding more frames or support twice as many slots. How else would you report a
complete change of all N contacts into N new contacts, for instance?
The kernel protocol is solid and works for all cases. Userland thus has access
to a complete solution.
Henrik
prev parent reply other threads:[~2015-04-23 18:52 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-03-30 18:54 [PATCH v2] Input - mt: Fix input_mt_get_slot_by_key Benjamin Tissoires
2015-04-06 16:33 ` Dmitry Torokhov
2015-04-07 13:17 ` Jiri Kosina
2015-04-23 16:49 ` Dmitry Torokhov
2015-04-23 17:10 ` Henrik Rydberg
2015-04-23 18:20 ` Dmitry Torokhov
2015-04-23 18:38 ` Benjamin Tissoires
2015-04-23 18:47 ` Dmitry Torokhov
2015-04-24 0:50 ` Peter Hutterer
2015-04-24 6:26 ` Henrik Rydberg
2015-04-27 3:52 ` Peter Hutterer
2015-04-27 18:02 ` Benjamin Tissoires
2015-04-23 18:52 ` Henrik Rydberg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55393F6B.8050904@bitmath.org \
--to=rydberg@bitmath.org \
--cc=benjamin.tissoires@redhat.com \
--cc=dmitry.torokhov@gmail.com \
--cc=jkosina@suse.cz \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=peter.hutterer@who-t.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).