From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1758029AbbDXPKn (ORCPT <rfc822;w@1wt.eu>);
	Fri, 24 Apr 2015 11:10:43 -0400
Received: from shelob.surriel.com ([74.92.59.67]:42904 "EHLO
	shelob.surriel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1755870AbbDXPKj (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Fri, 24 Apr 2015 11:10:39 -0400
Message-ID: <553A5CE7.4080200@surriel.com>
Date: Fri, 24 Apr 2015 11:10:31 -0400
From: Rik van Riel <riel@surriel.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Heiko Carstens <heiko.carstens@de.ibm.com>
CC: linux-kernel@vger.kernel.org, Andy Lutomirsky <amluto@amacapital.com>,
        Frederic Weisbecker <fweisbec@redhat.com>,
        Peter Zijlstra <peterz@infradead.org>,
        Luiz Capitulino <lcapitulino@redhat.com>,
        Marcelo Tosatti <mtosatti@redhat.com>,
        Clark Williams <williams@redhat.com>
Subject: Re: [PATCH] context_tracking: remove local_irq_save from __acct_update_integrals
References: <20150423215713.3334ae6f@annuminas.surriel.com> <20150424091156.GB4089@osiris>
In-Reply-To: <20150424091156.GB4089@osiris>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 04/24/2015 05:11 AM, Heiko Carstens wrote:
> On Thu, Apr 23, 2015 at 09:57:13PM -0400, Rik van Riel wrote:
>> diff --git a/kernel/tsacct.c b/kernel/tsacct.c
>> index 975cb49e32bf..0b967f116a6b 100644
>> --- a/kernel/tsacct.c
>> +++ b/kernel/tsacct.c
>> @@ -126,23 +126,29 @@ static void __acct_update_integrals(struct task_struct *tsk,
>>  	if (likely(tsk->mm)) {
>>  		cputime_t time, dtime;
>>  		struct timeval value;
>> -		unsigned long flags;
>>  		u64 delta;
>>
>> -		local_irq_save(flags);
>>  		time = stime + utime;
>>  		dtime = time - tsk->acct_timexpd;
>> +		/*
>> +		 * This code is called both from irq context and from
>> +		 * task context. There is a race where irq context advances
>> +		 * tsk->acct_timexpd to a value larger than time, creating
>> +		 * a negative value. In that case, the irq has already
>> +		 * updated the statistics.
>> +		 */
>> +		if (unlikely((signed long)dtime <= 0))
>> +			return;
> 
> FWIW, I think you either need a barrier() before the if-statement or use
> READ_ONCE() when reading tsk->acct_timexpd above.
> 
> Otherwise the compiler could (in theory at least) generate code which
> would translate to 
> 		if (unlikely(time <= tsk->acct_timexpd))
> in order to achieve the same result, no?
> 
> Besides that cputime_t might be 64 bit in size, therefore you don't have
> much of a guarentee that reading tsk->acct_timexpd happens atomically on
> 32 bit architectures, so you _may_ end up with garbage, no?

You are right on both counts. Thank you for pointing out what
should have been obvious...

Let me post a new patch :)

-- 
All rights reversed.