From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932358AbbD0Iqo (ORCPT ); Mon, 27 Apr 2015 04:46:44 -0400 Received: from mailout2.samsung.com ([203.254.224.25]:65383 "EHLO mailout2.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752862AbbD0Iql (ORCPT ); Mon, 27 Apr 2015 04:46:41 -0400 X-AuditID: cbfee691-f79ca6d00000456a-06-553df76ec3dd Message-id: <553DF76D.9000206@samsung.com> Date: Mon, 27 Apr 2015 17:46:37 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Sylwester Nawrocki Cc: mturquette@linaro.org, sboyd@codeaurora.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] clk: Show clock rate and error value when fail to set clock rate References: <1429528131-9075-1-git-send-email-cw00.choi@samsung.com> <55360C44.4020107@samsung.com> In-reply-to: <55360C44.4020107@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupjkeLIzCtJLcpLzFFi42JZI2JSopv33TbUYNkyTovLu+awWTydcJHN 4vCbdlaLH2e6WRxYPC739TJ53Lm2h82jb8sqRo/Pm+QCWKK4bFJSczLLUov07RK4Mk7eamEp mM5X8a75IlsD40zuLkZODgkBE4n5HX1sELaYxIV764FsLg4hgaWMEhuvHGWEKXr39Bc7RGIR o8SlGS+hnAeMEh/f/2MBqeIV0JI48vQKM4jNIqAq8brnLjuIzQYU3//iBtgKUYEwiZXTr0DV C0r8mHwPzBYR0JdYsuoiWA2zgK9Ex/RvYHOEBaIk/kxcyQRiCwmkSpxYug0szimgLXHl2zIg mwOoXk/i/kUtiFZ5ic1r3jKD3CYhsIpd4vG9TnaIewQkvk0+xAJSLyEgK7HpADPEY5ISB1fc YJnAKDYLyUWzEKbOQjJ1ASPzKkbR1ILkguKk9CJTveLE3OLSvHS95PzcTYzAaDr979nEHYz3 D1gfYhTgYFTi4ZWYaBsqxJpYVlyZe4jRFOiIicxSosn5wJjNK4k3NDYzsjA1MTU2Mrc0UxLn 1ZH+GSwkkJ5YkpqdmlqQWhRfVJqTWnyIkYmDU6qBcfvyII/JCma8vSz3nC/9T91r4yHZ8tvn yENdu4Kkh+H7AwomTvpfeOzur5x9X1xfp7y6Jc4y6+hZl9sZ0aYMQvHzJ6m+LLANYGDOWfNl ldGHuLk5xzrFVz+1c51Ts/ZC1m8u2TPW/9c8P5jGpWLu8E1mveheB4HVj2JfidutY5LncZp2 9M7f1UosxRmJhlrMRcWJAA8bOqyhAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrBIsWRmVeSWpSXmKPExsVy+t9jAd2877ahBst+Mlpc3jWHzeLphIts FofftLNa/DjTzeLA4nG5r5fJ4861PWwefVtWMXp83iQXwBLVwGiTkZqYklqkkJqXnJ+SmZdu q+QdHO8cb2pmYKhraGlhrqSQl5ibaqvk4hOg65aZA7RTSaEsMacUKBSQWFyspG+HaUJoiJuu BUxjhK5vSBBcj5EBGkhYw5hx8lYLS8F0vop3zRfZGhhncncxcnJICJhIvHv6ix3CFpO4cG89 WxcjF4eQwCJGiUszXrJDOA8YJT6+/8cCUsUroCVx5OkVZhCbRUBV4nXPXbBuNqD4/hc32EBs UYEwiZXTr0DVC0r8mHwPzBYR0JdYsuoiWA2zgK9Ex/RvYHOEBaIk/kxcyQRiCwmkSpxYug0s zimgLXHl2zIgmwOoXk/i/kUtiFZ5ic1r3jJPYBSYhWTDLISqWUiqFjAyr2IUTS1ILihOSs81 1CtOzC0uzUvXS87P3cQIjtVnUjsYVzZYHGIU4GBU4uGVmGgbKsSaWFZcmXuIUYKDWUmEd8dn oBBvSmJlVWpRfnxRaU5q8SFGU6D/JzJLiSbnA9NIXkm8obGJmZGlkbmhhZGxuZI47xxduVAh gfTEktTs1NSC1CKYPiYOTqkGxrgPQr1CXqv5HBlfcOxLUJ74+Uef7P8VWz89ECy9nsPR5bm0 b9aN88mbuY6wOqVPZPqb5771W6LFkX9btVTniWwzCb6xSFnTbmcAn3e+9dyF6e7Top2tvjqv Xs4jtobHbc57wy+ecpVGGWX+0VVzP8tM3btV5NbqrGDGFZmP+rfaWBxd28Dpr8RSnJFoqMVc VJwIAIyijIbrAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sylwester, On 04/21/2015 05:37 PM, Sylwester Nawrocki wrote: > Hi Chanwoo, > > On 20/04/15 13:08, Chanwoo Choi wrote: >> This patch shows the current clock rate nad error value when clk_set_rate() >> fail to set the clock rate because log messgae means only the clock rate. >> >> Cc: Mike Turquette >> Cc: Stephen Boyd >> Cc: Sylwester Nawrocki >> Signed-off-by: Chanwoo Choi >> --- >> Changes from v1: >> - Add error value of clk-set_rate() with current clock rate >> >> drivers/clk/clk-conf.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/clk/clk-conf.c b/drivers/clk/clk-conf.c >> index aad4796..2b6375f 100644 >> --- a/drivers/clk/clk-conf.c >> +++ b/drivers/clk/clk-conf.c >> @@ -107,8 +107,9 @@ static int __set_clk_rates(struct device_node *node, bool clk_supplier) >> >> rc = clk_set_rate(clk, rate); >> if (rc < 0) >> - pr_err("clk: couldn't set %s clock rate: %d\n", >> - __clk_get_name(clk), rc); >> + pr_err("clk: couldn't set %s rate to %ld (%d)\n", >> + __clk_get_name(clk), clk_get_rate(clk), >> + rc); > > Apologies for my previous misleading comment, with this patch > you log current clock rate as the rate which was attempted to > be set. And these two will likely be different when clk_set_rate() > failed. So it should rather be: > > pr_err("clk: couldn't set %s clk rate to %ld (%d)\n", > __clk_get_name(clk), rate, rc); I'll modify it as following without error value. If I add the error value, the number of character are over 80. pr_err("clk: couldn't set %s clk rate to %ld\n", __clk_get_name(clk), rate); Thanks, Chanwoo Choi