From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932418AbbD0Ivu (ORCPT ); Mon, 27 Apr 2015 04:51:50 -0400 Received: from mailout1.w1.samsung.com ([210.118.77.11]:30972 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932118AbbD0Ivt (ORCPT ); Mon, 27 Apr 2015 04:51:49 -0400 X-AuditID: cbfec7f4-f79c56d0000012ee-e2-553df8a46d7d Message-id: <553DF890.9020002@samsung.com> Date: Mon, 27 Apr 2015 10:51:28 +0200 From: Sylwester Nawrocki User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0 MIME-version: 1.0 To: Chanwoo Choi Cc: mturquette@linaro.org, sboyd@codeaurora.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] clk: Show clock rate and error value when fail to set clock rate References: <1429528131-9075-1-git-send-email-cw00.choi@samsung.com> <55360C44.4020107@samsung.com> <553DF76D.9000206@samsung.com> In-reply-to: <553DF76D.9000206@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrCLMWRmVeSWpSXmKPExsVy+t/xK7pLftiGGhy8amRx/ctzVovLu+aw WTydcJHN4seZbhYHFo/Lfb1MHneu7WHz6NuyitHj8ya5AJYoLpuU1JzMstQifbsErowPj1oZ Czq4KzqnfGVrYDzM0cXIySEhYCLRvOseG4QtJnHh3nowW0hgKaPEqrnMXYxcQPZzRokrT36z gCR4BbQk7q++xAhiswioSix4+RysgU3AUKL3aB9QnINDVCBC4vZlTohyQYkfk++BtYoIaEjM /HsFrJVZwFeiY/o3ZhBbWCBK4s/ElUwQu1oYJSZ9+ccCModTQFui46YjiMksoCdx/6IWRKu8 xOY1b5knMArMQrJhFkLVLCRVCxiZVzGKppYmFxQnpeca6hUn5haX5qXrJefnbmKEhO2XHYyL j1kdYhTgYFTi4TVYZhsqxJpYVlyZe4hRgoNZSYR3x2egEG9KYmVValF+fFFpTmrxIUZpDhYl cd65u96HCAmkJ5akZqemFqQWwWSZODilGhjd6osMPnxuLHmaxLosX5d7U37T8zTl6Ue8VQ2W l28PZKyv7FE6lG/MbbNY+0biIRbRjFsF1pGNVscvrd8gE2zV+O3lzh6HK/e9Xm79tkW2fTvv 5wlcTwtr2oNf/rgorSW7rXdT7heRR/MX/+2JWbdmqeaaOXv1cvPOnrHYY7LfL82u6ubMWZuU WIozEg21mIuKEwHg3DosVwIAAA== Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Chanwoo, On 27/04/15 10:46, Chanwoo Choi wrote: >>> diff --git a/drivers/clk/clk-conf.c b/drivers/clk/clk-conf.c >>> >> index aad4796..2b6375f 100644 >>> >> --- a/drivers/clk/clk-conf.c >>> >> +++ b/drivers/clk/clk-conf.c >>> >> @@ -107,8 +107,9 @@ static int __set_clk_rates(struct device_node *node, bool clk_supplier) >>> >> >>> >> rc = clk_set_rate(clk, rate); >>> >> if (rc < 0) >>> >> - pr_err("clk: couldn't set %s clock rate: %d\n", >>> >> - __clk_get_name(clk), rc); >>> >> + pr_err("clk: couldn't set %s rate to %ld (%d)\n", >>> >> + __clk_get_name(clk), clk_get_rate(clk), >>> >> + rc); >> > >> > Apologies for my previous misleading comment, with this patch >> > you log current clock rate as the rate which was attempted to >> > be set. And these two will likely be different when clk_set_rate() >> > failed. So it should rather be: >> > >> > pr_err("clk: couldn't set %s clk rate to %ld (%d)\n", >> > __clk_get_name(clk), rate, rc); > > I'll modify it as following without error value. > If I add the error value, the number of character are over 80. > pr_err("clk: couldn't set %s clk rate to %ld\n", > __clk_get_name(clk), rate); I wouldn't worry about line length over 80 characters, it not a hard rule. Let's leave the error code as it might be useful for debugging. -- Regards, Sylwester