From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932443AbbD0JDW (ORCPT ); Mon, 27 Apr 2015 05:03:22 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:33671 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932196AbbD0JDS (ORCPT ); Mon, 27 Apr 2015 05:03:18 -0400 X-AuditID: cbfee68e-f79c56d000006efb-1d-553dfb538b5f Message-id: <553DFB53.1020606@samsung.com> Date: Mon, 27 Apr 2015 18:03:15 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Sylwester Nawrocki Cc: mturquette@linaro.org, sboyd@codeaurora.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] clk: Show clock rate and error value when fail to set clock rate References: <1429528131-9075-1-git-send-email-cw00.choi@samsung.com> <55360C44.4020107@samsung.com> <553DF76D.9000206@samsung.com> <553DF890.9020002@samsung.com> In-reply-to: <553DF890.9020002@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFuplkeLIzCtJLcpLzFFi42JZI2JSrBv82zbU4OUsS4vLu+awWTydcJHN 4vCbdlaLH2e6WRxYPC739TJ53Lm2h82jb8sqRo/Pm+QCWKK4bFJSczLLUov07RK4MubMmMdW 0MBTcWzlNuYGxi2cXYycHBICJhLd6zeyQdhiEhfurQeyuTiEBJYyStycspili5EDrKhziz9E fBGjRMP1flYI5wGjxIRTl8C6eQW0JP7tusUOYrMIqEps+7KSGcRmA4rvf3EDrEZUIExi5fQr LBD1ghI/Jt8Ds0UE9CWWrLoIVsMs4CvRMf0bWK+wQJTEn4krmUBssItOvfQBsTkFtCXWL7nC DHIcs4CexP2LWhCt8hKb17xlBrlNQmATu8TS/mtsEPcISHybfAjqGVmJTQeYIR6WlDi44gbL BEaxWUgumoUwdRaSqQsYmVcxiqYWJBcUJ6UXGekVJ+YWl+al6yXn525iBMbS6X/P+nYw3jxg fYhRgINRiYdXYqJtqBBrYllxZe4hRlOgIyYyS4km5wMjNq8k3tDYzMjC1MTU2Mjc0kxJnDdB 6mewkEB6YklqdmpqQWpRfFFpTmrxIUYmDk6pBsaWxEUBU+89FVuoafaec35WBHeVbcx+mctf osqWG23RMNt2zCfGqW2ezMPmZ/VHD9dqfN6fzOV0JfiFxrvDdvMWG9R//fDt9mr/Od+veKSc 1I86nXUx7/+egKfNXpoCZvlTc9tzEv6qt91+ax14nPPkuwd3ci+GCDHOE1HNXM/b2Lmiaxpr 00olluKMREMt5qLiRADuymrroAIAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrOIsWRmVeSWpSXmKPExsVy+t9jAd3g37ahBst+mlhc3jWHzeLphIts FofftLNa/DjTzeLA4nG5r5fJ4861PWwefVtWMXp83iQXwBLVwGiTkZqYklqkkJqXnJ+SmZdu q+QdHO8cb2pmYKhraGlhrqSQl5ibaqvk4hOg65aZA7RTSaEsMacUKBSQWFyspG+HaUJoiJuu BUxjhK5vSBBcj5EBGkhYw5gxZ8Y8toIGnopjK7cxNzBu4exi5OCQEDCR6Nzi38XICWSKSVy4 t56ti5GLQ0hgEaNEw/V+VgjnAaPEhFOX2ECqeAW0JP7tusUOYrMIqEps+7KSGcRmA4rvf3ED rEZUIExi5fQrLBD1ghI/Jt8Ds0UE9CWWrLoIVsMs4CvRMf0bWK+wQJTEn4krmUBsIYGljBKn XvqA2JwC2hLrl1xhBjmUWUBP4v5FLYhWeYnNa94yT2AUmIVkwyyEqllIqhYwMq9iFE0tSC4o TkrPNdQrTswtLs1L10vOz93ECI7UZ1I7GFc2WBxiFOBgVOLhlZhoGyrEmlhWXJl7iFGCg1lJ hHfHZ6AQb0piZVVqUX58UWlOavEhRlOg/ycyS4km5wOTSF5JvKGxiZmRpZG5oYWRsbmSOO8c XblQIYH0xJLU7NTUgtQimD4mDk6pBkb38B+zUvIduDhvrhM6tCS9vVNF8UPuI70fvqnXtfmW NpzKOO3t3mWedvYR46MGySn7LvhxLKys4Ql//PfqtTsR26X4d0U/bKqb/f6nypSKsiXN33fI vGC/6C8htWDXYZei+yeVpfPqF/2d8Og2x4JP15WfrvcQDrhXmbZU8Y2DgdfHQ9JWXNeVWIoz Eg21mIuKEwGhDzrz6gIAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Sylwester, On 04/27/2015 05:51 PM, Sylwester Nawrocki wrote: > Hi Chanwoo, > > On 27/04/15 10:46, Chanwoo Choi wrote: >>>> diff --git a/drivers/clk/clk-conf.c b/drivers/clk/clk-conf.c >>>>>> index aad4796..2b6375f 100644 >>>>>> --- a/drivers/clk/clk-conf.c >>>>>> +++ b/drivers/clk/clk-conf.c >>>>>> @@ -107,8 +107,9 @@ static int __set_clk_rates(struct device_node *node, bool clk_supplier) >>>>>> >>>>>> rc = clk_set_rate(clk, rate); >>>>>> if (rc < 0) >>>>>> - pr_err("clk: couldn't set %s clock rate: %d\n", >>>>>> - __clk_get_name(clk), rc); >>>>>> + pr_err("clk: couldn't set %s rate to %ld (%d)\n", >>>>>> + __clk_get_name(clk), clk_get_rate(clk), >>>>>> + rc); >>>> >>>> Apologies for my previous misleading comment, with this patch >>>> you log current clock rate as the rate which was attempted to >>>> be set. And these two will likely be different when clk_set_rate() >>>> failed. So it should rather be: >>>> >>>> pr_err("clk: couldn't set %s clk rate to %ld (%d)\n", >>>> __clk_get_name(clk), rate, rc); >> >> I'll modify it as following without error value. >> If I add the error value, the number of character are over 80. >> pr_err("clk: couldn't set %s clk rate to %ld\n", >> __clk_get_name(clk), rate); > > I wouldn't worry about line length over 80 characters, it not a hard rule. > Let's leave the error code as it might be useful for debugging. > OK, I'll add error value again. Thanks, Chanwoo Choi