From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932502AbbD0JGf (ORCPT ); Mon, 27 Apr 2015 05:06:35 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:34377 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932169AbbD0JGc (ORCPT ); Mon, 27 Apr 2015 05:06:32 -0400 X-AuditID: cbfee68e-f79c56d000006efb-4c-553dfc176687 Message-id: <553DFC16.20301@samsung.com> Date: Mon, 27 Apr 2015 18:06:30 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Sylwester Nawrocki Cc: mturquette@linaro.org, sboyd@codeaurora.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] clk: Show clock rate and error value when fail to set clock rate References: <1429528131-9075-1-git-send-email-cw00.choi@samsung.com> <55360C44.4020107@samsung.com> <553DF76D.9000206@samsung.com> <553DF890.9020002@samsung.com> <553DFB53.1020606@samsung.com> In-reply-to: <553DFB53.1020606@samsung.com> Content-type: text/plain; charset=windows-1252 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFupnkeLIzCtJLcpLzFFi42JZI2JSrCv+xzbU4NlXLYvLu+awWTydcJHN 4vCbdlaLH2e6WRxYPC739TJ53Lm2h82jb8sqRo/Pm+QCWKK4bFJSczLLUov07RK4Mp5/Osda sIGvYtrbN0wNjLO5uxg5OSQETCROzLrJCmGLSVy4t56ti5GLQ0hgKaPEohnTGWGKZr09yQqR mM4ocWrKdyjnAaPE6a7bbCBVvAIaEg8PrAPrYBFQleg49g0sziagJbH/xQ0wW1QgTGLl9Css EPWCEj8m3wOzRQT0JZasughWwyzgK9Ex/RsziC0sECXxZ+JKJohlRxglDq76yA6S4BTQlrj+ +gJQMwdQg57E/YtaEL3yEpvXvGUGqZcQWMcucfLMXjaIgwQkvk0+BFYvISArsekAM8RnkhIH V9xgmcAoNgvJSbMQps5CMnUBI/MqRtHUguSC4qT0IiO94sTc4tK8dL3k/NxNjMB4Ov3vWd8O xpsHrA8xCnAwKvHwSky0DRViTSwrrsw9xGgKdMREZinR5Hxg1OaVxBsamxlZmJqYGhuZW5op ifMmSP0MFhJITyxJzU5NLUgtii8qzUktPsTIxMEp1cAY+yCyr4Wv72L+9NNrVxlclCysOSMV JDJ5SgTLulPXJ2tuSPq+uEt0lvSptdt3Ms7TFYu9oducks2sqnE1eeG8+ccS5BMb9zZ2W1sI WzilSJU7/8wqvJ3Gx/usaEqhGEM5/7wgxqhJ/swqn7q9Sic731LlaHCuZovyXrjX4fzHrzbm GTomkkosxRmJhlrMRcWJANIwGciiAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrJIsWRmVeSWpSXmKPExsVy+t9jQV3xP7ahBgv3qFlc3jWHzeLphIts FofftLNa/DjTzeLA4nG5r5fJ4861PWwefVtWMXp83iQXwBLVwGiTkZqYklqkkJqXnJ+SmZdu q+QdHO8cb2pmYKhraGlhrqSQl5ibaqvk4hOg65aZA7RTSaEsMacUKBSQWFyspG+HaUJoiJuu BUxjhK5vSBBcj5EBGkhYw5jx/NM51oINfBXT3r5hamCczd3FyMkhIWAiMevtSVYIW0ziwr31 bF2MXBxCAtMZJU5N+c4K4TxglDjddZsNpIpXQEPi4YF1jCA2i4CqRMexb2BxNgEtif0vboDZ ogJhEiunX2GBqBeU+DH5HpgtIqAvsWTVRbAaZgFfiY7p35hBbGGBKIk/E1cyQSw7wihxcNVH dpAEp4C2xPXXF4CaOYAa9CTuX9SC6JWX2LzmLfMERoFZSFbMQqiahaRqASPzKkbR1ILkguKk 9FxDveLE3OLSvHS95PzcTYzgaH0mtYNxZYPFIUYBDkYlHl6JibahQqyJZcWVuYcYJTiYlUR4 d3wGCvGmJFZWpRblxxeV5qQWH2I0BQbARGYp0eR8YCLJK4k3NDYxM7I0Mje0MDI2VxLnnaMr FyokkJ5YkpqdmlqQWgTTx8TBKdXAWJiXr/83SNXiOMvEia92vhF0cPz7dtvli4t6dj7miM3e dyQ9kmO9ppfhct6f3Wfi+CZ6ScyJPD63z2t1laN99UuLSS73Zj/gSrNXWC+/O+XOotPNoVP8 P1RbaqkIPyu31JtVFeiduGv9gxVPZLJvL7z87FGLxcKT/mZfGk+ucOE5Zi78NlrNVomlOCPR UIu5qDgRAEmz1FTsAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/27/2015 06:03 PM, Chanwoo Choi wrote: > Hi Sylwester, > > On 04/27/2015 05:51 PM, Sylwester Nawrocki wrote: >> Hi Chanwoo, >> >> On 27/04/15 10:46, Chanwoo Choi wrote: >>>>> diff --git a/drivers/clk/clk-conf.c b/drivers/clk/clk-conf.c >>>>>>> index aad4796..2b6375f 100644 >>>>>>> --- a/drivers/clk/clk-conf.c >>>>>>> +++ b/drivers/clk/clk-conf.c >>>>>>> @@ -107,8 +107,9 @@ static int __set_clk_rates(struct device_node *node, bool clk_supplier) >>>>>>> >>>>>>> rc = clk_set_rate(clk, rate); >>>>>>> if (rc < 0) >>>>>>> - pr_err("clk: couldn't set %s clock rate: %d\n", >>>>>>> - __clk_get_name(clk), rc); >>>>>>> + pr_err("clk: couldn't set %s rate to %ld (%d)\n", >>>>>>> + __clk_get_name(clk), clk_get_rate(clk), >>>>>>> + rc); >>>>> >>>>> Apologies for my previous misleading comment, with this patch >>>>> you log current clock rate as the rate which was attempted to >>>>> be set. And these two will likely be different when clk_set_rate() >>>>> failed. So it should rather be: >>>>> >>>>> pr_err("clk: couldn't set %s clk rate to %ld (%d)\n", >>>>> __clk_get_name(clk), rate, rc); >>> >>> I'll modify it as following without error value. >>> If I add the error value, the number of character are over 80. >>> pr_err("clk: couldn't set %s clk rate to %ld\n", >>> __clk_get_name(clk), rate); >> >> I wouldn't worry about line length over 80 characters, it not a hard rule. >> Let's leave the error code as it might be useful for debugging. >> > > OK, I'll add error value again. As you commented, I'll add all information as following: pr_err("clk: couldn't set %s clk rate to %ld (%d), current rate: %ld\n", __clk_get_name(clk), rate, rc, clk_get_rate(clk)); Thanks, Chanwoo Choi