From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S933252AbbD1JLM (ORCPT <rfc822;w@1wt.eu>);
	Tue, 28 Apr 2015 05:11:12 -0400
Received: from mail-wg0-f45.google.com ([74.125.82.45]:35488 "EHLO
	mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S932894AbbD1JLI (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 28 Apr 2015 05:11:08 -0400
Message-ID: <553F4EA9.4000307@gmail.com>
Date: Tue, 28 Apr 2015 10:11:05 +0100
From: Jon Hunter <jgchunter@gmail.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Tomeu Vizoso <tomeu.vizoso@collabora.com>, linux-tegra@vger.kernel.org
CC: Mark Rutland <mark.rutland@arm.com>, Alexandre Courbot <gnurou@gmail.com>,
        Russell King <linux@arm.linux.org.uk>, Pawel Moll <pawel.moll@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Stephen Warren <swarren@wwwdotorg.org>, linux-kernel@vger.kernel.org,
        Mikko Perttunen <mikko.perttunen@kapsi.fi>, devicetree@vger.kernel.org,
        Rob Herring <robh+dt@kernel.org>,
        Tuomas Tynkkynen <ttynkkynen@nvidia.com>,
        Kumar Gala <galak@codeaurora.org>,
        Thierry Reding <thierry.reding@gmail.com>,
        linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v3] ARM: tegra: Correct which USB controller has the UTMI
 pad registers
References: <551D61A5.2010102@kapsi.fi> <1428045671-2333-1-git-send-email-tomeu.vizoso@collabora.com>
In-Reply-To: <1428045671-2333-1-git-send-email-tomeu.vizoso@collabora.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 04/03/2015 08:21 AM, Tomeu Vizoso wrote:
> It should be the first controller, not the second. The indexes of the
> usb resets were also wrong and have been fixed.
> 
> The issue was caused by the changes in 308efde ("ARM: tegra: Add resets
> & has-utmi-pad-registers flag to all USB PHYs") being misapplied by git
> due to the patch context being insufficient.
> 
> This broke USB after 6261b06 ("regulator: Defer lookup of supply to
> regulator_get"), because it changed the order in which the controllers
> were probed.
> 
> The fix for this issue was suggested by Mikko Perttunen and Tuomas
> Tynkkynen.
> 
> Signed-off-by: Tomeu Vizoso <tomeu.vizoso@collabora.com>
> Cc: Mikko Perttunen <mikko.perttunen@kapsi.fi>
> Cc: Tuomas Tynkkynen <ttynkkynen@nvidia.com>
> ---
> Hi,
> 
> hope I have gotten it right this time, but please do check :)

FWIW, this works for me.

Tested-by: Jon Hunter <jonathanh@nvidia.com>

Cheers
Jon