From: Denys Vlasenko <dvlasenk@redhat.com>
To: "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Steven Rostedt <rostedt@goodmis.org>,
Borislav Petkov <bp@alien8.de>,
Andy Lutomirski <luto@amacapital.net>,
Oleg Nesterov <oleg@redhat.com>,
Frederic Weisbecker <fweisbec@gmail.com>,
Alexei Starovoitov <ast@plumgrid.com>,
Will Drewry <wad@chromium.org>, Kees Cook <keescook@chromium.org>,
x86@kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] x86/asm/entry/64: Tidy up JZ insns after TESTs
Date: Tue, 28 Apr 2015 12:05:34 +0200 [thread overview]
Message-ID: <553F5B6E.4040307@redhat.com> (raw)
In-Reply-To: <553EB536.8020404@zytor.com>
On 04/28/2015 12:16 AM, H. Peter Anvin wrote:
> On 04/27/2015 06:21 AM, Denys Vlasenko wrote:
>>
>> diff --git a/arch/x86/kernel/entry_64.S b/arch/x86/kernel/entry_64.S
>> index e952f6b..8f8b22a 100644
>> --- a/arch/x86/kernel/entry_64.S
>> +++ b/arch/x86/kernel/entry_64.S
>> @@ -666,7 +666,7 @@ END(irq_entries_start)
>> leaq -RBP(%rsp),%rdi /* arg1 for \func (pointer to pt_regs) */
>>
>> testl $3, CS-RBP(%rsp)
>> - je 1f
>> + jz 1f
>> SWAPGS
>> 1:
>
> Please don't insert tabs between opcode and operand unless that is the
> style of the surrounding code.
The next patch inserts tab in the preceding TEST insn too,
converting entire mini-block of code to "tab" style.
next prev parent reply other threads:[~2015-04-28 10:06 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 13:21 [PATCH 1/2] x86/asm/entry/64: Tidy up JZ insns after TESTs Denys Vlasenko
2015-04-27 13:21 ` [PATCH 2/2] x86/asm/entry/64: Clean up usage of TEST insns Denys Vlasenko
2015-05-08 9:25 ` [tip:x86/asm] " tip-bot for Denys Vlasenko
2015-04-27 21:13 ` [PATCH 1/2] x86/asm/entry/64: Tidy up JZ insns after TESTs Andy Lutomirski
2015-04-27 22:16 ` H. Peter Anvin
2015-04-28 10:05 ` Denys Vlasenko [this message]
2015-05-08 9:25 ` [tip:x86/asm] " tip-bot for Denys Vlasenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553F5B6E.4040307@redhat.com \
--to=dvlasenk@redhat.com \
--cc=ast@plumgrid.com \
--cc=bp@alien8.de \
--cc=fweisbec@gmail.com \
--cc=hpa@zytor.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=mingo@kernel.org \
--cc=oleg@redhat.com \
--cc=rostedt@goodmis.org \
--cc=torvalds@linux-foundation.org \
--cc=wad@chromium.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).