Re: [PATCH] ipmi: Fix a problem that messages are not issued in run_to_completion mode

[Hidehiro Kawai <hidehiro.kawai.ez@hitachi.com>]

Hello,

(2015/04/24 22:00), Corey Minyard wrote:
> Ah, yes, you are correct.  Queued for 4.1.  Thanks.

Thank you for the review.

By the way, I'm planning some enhancements of IPMI driver
in panic context.  Currently, we can call panic notifiers
before crash_kexec() by specifying crash_kexec_post_notifiers
as a boot parameter.  By utilizing this feature, we can write
SEL records before entering kdump process; we can save some
information even if kdump fails.  Here, notifier calls
shouldn't prevent the kdump process.  So, the reliability of
panic notifier calls is very important.

I noticed that there are possible infinite loops in the
panic notifier call of IPMI driver (we assume BMC is
unreliable).  To evict possible infinite loops, I'm considering
introducing some retry timeout or retry count limit to the
run_to_completion procedure.

Do you have any opinions?

-- 
Hidehiro Kawai
Hitachi, Ltd. Research & Development Group