From: SF Markus Elfring <elfring@users.sourceforge.net>
To: Julia Lawall <Julia.Lawall@lip6.fr>
Cc: Gleb Natapov <gleb@kernel.org>,
"Michael S . Tsirkin" <mst@redhat.com>,
zhanghy@sangfor.com, jasowang@redhat.com,
kernel-janitors@vger.kernel.org,
Paolo Bonzini <pbonzini@redhat.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] KVM: x86: drop unneeded null test
Date: Tue, 28 Apr 2015 19:21:39 +0200 [thread overview]
Message-ID: <553FC1A3.70206@users.sourceforge.net> (raw)
In-Reply-To: <1430166934-30834-1-git-send-email-Julia.Lawall@lip6.fr>
> If the null test is needed, the call to cancel_delayed_work_sync would have
> already crashed. Normally, the destroy function should only be called
> if the init functoin has succeeded, in which case ioapic is not null.
Does your commit message need a small fix?
Regards,
Markus
prev parent reply other threads:[~2015-04-28 17:23 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-27 20:35 [PATCH] KVM: x86: drop unneeded null test Julia Lawall
2015-04-27 20:50 ` Michael S. Tsirkin
2015-04-28 9:57 ` Paolo Bonzini
2015-04-28 17:21 ` SF Markus Elfring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=553FC1A3.70206@users.sourceforge.net \
--to=elfring@users.sourceforge.net \
--cc=Julia.Lawall@lip6.fr \
--cc=gleb@kernel.org \
--cc=hpa@zytor.com \
--cc=jasowang@redhat.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
--cc=zhanghy@sangfor.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).