From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1030532AbbD1RXZ (ORCPT ); Tue, 28 Apr 2015 13:23:25 -0400 Received: from mout.web.de ([212.227.15.14]:54732 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1030328AbbD1RXV (ORCPT ); Tue, 28 Apr 2015 13:23:21 -0400 Message-ID: <553FC1A3.70206@users.sourceforge.net> Date: Tue, 28 Apr 2015 19:21:39 +0200 From: SF Markus Elfring User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Julia Lawall CC: Gleb Natapov , "Michael S . Tsirkin" , zhanghy@sangfor.com, jasowang@redhat.com, kernel-janitors@vger.kernel.org, Paolo Bonzini , Thomas Gleixner , Ingo Molnar , "H. Peter Anvin" , x86@kernel.org, kvm@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] KVM: x86: drop unneeded null test References: <1430166934-30834-1-git-send-email-Julia.Lawall@lip6.fr> In-Reply-To: <1430166934-30834-1-git-send-email-Julia.Lawall@lip6.fr> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K0:ay0ujKHDFeykg9rRGPYvFGJZ94nk1ygEhuTA+mVPGqlC+BR1ScG CxTPUarzguuh+9H1qZPphDScTTpqg+W7voA89jCTlZFQe8M5yA1UfJQt+UE038+U1aMl4Do IX3CwYjF/ARV3RBAaBbdH6DKQqUzS4KGOT8LPNTxVlNveuIxNW61yvXej4ju0p+4DAl13rI IR5kCXocSKQy8mFOWS05w== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org > If the null test is needed, the call to cancel_delayed_work_sync would have > already crashed. Normally, the destroy function should only be called > if the init functoin has succeeded, in which case ioapic is not null. Does your commit message need a small fix? Regards, Markus