From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1423031AbbD2NQw (ORCPT <rfc822;w@1wt.eu>);
	Wed, 29 Apr 2015 09:16:52 -0400
Received: from mga14.intel.com ([192.55.52.115]:25669 "EHLO mga14.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1422821AbbD2NQv (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Wed, 29 Apr 2015 09:16:51 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.11,671,1422950400"; 
   d="scan'208";a="687439564"
Message-ID: <5540D93D.5010700@intel.com>
Date: Wed, 29 Apr 2015 16:14:37 +0300
From: Adrian Hunter <adrian.hunter@intel.com>
Organization: Intel Finland Oy, Registered Address: PL 281, 00181 Helsinki,
 Business Identity Code: 0357606 - 4, Domiciled in Helsinki 
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Jiri Olsa <jolsa@redhat.com>
CC: Arnaldo Carvalho de Melo <acme@kernel.org>,
        Peter Zijlstra <peterz@infradead.org>, linux-kernel@vger.kernel.org,
        David Ahern <dsahern@gmail.com>,
        Frederic Weisbecker <fweisbec@gmail.com>,
        Namhyung Kim <namhyung@gmail.com>,
        Stephane Eranian <eranian@google.com>
Subject: Re: [PATCH V3 11/25] perf record: Add AUX area tracing Snapshot Mode
 support
References: <1429903807-20559-1-git-send-email-adrian.hunter@intel.com> <1429903807-20559-12-git-send-email-adrian.hunter@intel.com> <20150428132446.GA3563@krava.redhat.com>
In-Reply-To: <20150428132446.GA3563@krava.redhat.com>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 28/04/15 16:24, Jiri Olsa wrote:
> On Fri, Apr 24, 2015 at 10:29:53PM +0300, Adrian Hunter wrote:
> 
> SNIP
> 
>>  	char msg[512];
>> @@ -238,7 +302,8 @@ try_again:
>>  	}
>>  
>>  	if (perf_evlist__mmap_ex(evlist, opts->mmap_pages, false,
>> -				 opts->auxtrace_mmap_pages, false) < 0) {
>> +				 opts->auxtrace_mmap_pages,
>> +				 opts->auxtrace_snapshot_mode) < 0) {
>>  		if (errno == EPERM) {
>>  			pr_err("Permission error mapping pages.\n"
>>  			       "Consider increasing "
>> @@ -349,7 +414,7 @@ static int record__mmap_read_all(struct record *rec)
>>  			}
>>  		}
>>  
>> -		if (mm->base &&
>> +		if (mm->base && !rec->opts.auxtrace_snapshot_mode &&
>>  		    record__auxtrace_mmap_read(rec, mm) != 0) {
>>  			rc = -1;
>>  			goto out;
>> @@ -404,6 +469,8 @@ static void workload_exec_failed_signal(int signo __maybe_unused,
>>  	child_finished = 1;
>>  }
>>  
>> +static void snapshot_sig_handler(int sig);
> 
> seems there's no need for forward declaration,
> you can define the function right here, no?

snapshot_sig_handler is dependent on "record" so the forward
declaration does seem to be needed.