Re: [GIT PULL] kdbus for 4.1-rc1

Greg Kroah-Hartman
2015-04-15T09:10:01Z

On Wed, Apr 15, 2015 at 10:54:41AM +0200, Jiri Kosina wrote:
> On Wed, 15 Apr 2015, Greg Kroah-Hartman wrote:
>
> > If you have a technical reason for why this code shouldn't be merged,
> > great, please let me know and we can work to address that. Andy and Al
> > have spent time reviewing and giving us comments, and that's wonderful
> > and valuable and is why I treat their comments seriously. If you are
> > interested in the code, please review it, otherwise I don't see what
> > this adds to the conversation at all, do you?
>
> You've actually touched another issue I see here, and that is -- the code
> is complex like crazy.
>
> I've spent big part of past two days trying to get my head around it, but
> I am still far away from getting at least the 1000 miles overview of how
> exactly the message passing is designed.
>
> I understand that the primary reason for this complexity is probably the
> dbus protocol specification itself.

Yes it is.

> But the problem really is that I don't think you've received even a single
> Reviewed-by: from someone who hasn't been directly involved in developing
> the code, right?

I've asked for it, but finding people to review code is hard, as you
know. It's only 13k lines long, smaller than a serial port driver (my
unit of code review), so it's not all that big.

It's smaller than the USB3 host controller driver as well, and very few
people ever reviewed that beast :)

> For something that's potentially such a core mechanism as a completely
> new, massively-adopted IPC, this does send a warning singal.

If you know of a way to force others to review code, please let me know.

thanks,

greg k-h