From: David Vrabel <david.vrabel@citrix.com>
To: Boris Ostrovsky <boris.ostrovsky@oracle.com>,
<david.vrabel@citrix.com>, <konrad.wilk@oracle.com>
Cc: <xen-devel@lists.xenproject.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [Xen-devel] [PATCH v3] xen: Suspend ticks on all CPUs during suspend
Date: Wed, 29 Apr 2015 17:10:34 +0100 [thread overview]
Message-ID: <5541027A.90206@citrix.com> (raw)
In-Reply-To: <1430261180-15382-1-git-send-email-boris.ostrovsky@oracle.com>
On 28/04/15 23:46, Boris Ostrovsky wrote:
> Commit 77e32c89a711 ("clockevents: Manage device's state separately for
> the core") decouples clockevent device's modes from states. With this
> change when a Xen guest tries to resume, it won't be calling its
> set_mode op which needs to be done on each VCPU in order to make the
> hypervisor aware that we are in oneshot mode.
>
> This happens because clockevents_tick_resume() (which is an intermediate
> step of resuming ticks on a processor) doesn't call clockevents_set_state()
> anymore and because during suspend clockevent devices on all VCPUs (except
> for the one doing the suspend) are left in ONESHOT state. As result, during
> resume the clockevents state machine will assume that device is already
> where it should be and doesn't need to be updated.
>
> To avoid this problem we should suspend ticks on all VCPUs during
> suspend.
Applied to for-linus-4.1b, thanks.
David
prev parent reply other threads:[~2015-04-29 16:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-28 22:46 [PATCH v3] xen: Suspend ticks on all CPUs during suspend Boris Ostrovsky
2015-04-29 16:10 ` David Vrabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5541027A.90206@citrix.com \
--to=david.vrabel@citrix.com \
--cc=boris.ostrovsky@oracle.com \
--cc=konrad.wilk@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox