From: Daniel Borkmann <daniel@iogearbox.net>
To: Pranith Kumar <bobby.prani@gmail.com>,
mancha security <mancha1@zoho.com>
Cc: "H. Peter Anvin" <hpa@linux.intel.com>,
LKML <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>
Subject: Re: [PATCH] compiler-intel: fix wrong compiler barrier() macro
Date: Wed, 29 Apr 2015 18:59:34 +0200 [thread overview]
Message-ID: <55410DF6.3090901@iogearbox.net> (raw)
In-Reply-To: <CAJhHMCA1eqcvc3Y2j6OZ1DWT-Cz=YOuxBtxC7t=Zu_onmJreAA@mail.gmail.com>
On 04/29/2015 06:40 PM, Pranith Kumar wrote:
> On Wed, Apr 29, 2015 at 10:59 AM, mancha security <mancha1@zoho.com> wrote:
>>
>> The problem is that ICC defines __GNUC__ so barrier() gets defined
>> in compiler-gcc.h. Your commit removed an #undef from compiler-intel.h
>> so compiler.h will never define barrier to __memory_barrier().
>
> OK, I see your point. But, ICC has support for GCC inline assembly. So
> the change does not seem to be making any difference. We are using our
> own asm barrier rather than the inbuilt one provided by ICC.
It does make a difference: gcc inline assembly is not supported by
/ecc/, see that it's wrapped within the ifdef __ECC part. I believe,
that should be for ia64 which we have under arch/, no?
next prev parent reply other threads:[~2015-04-29 16:59 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-29 14:42 [PATCH] compiler-intel: fix wrong compiler barrier() macro Daniel Borkmann
2015-04-29 14:51 ` Pranith Kumar
2015-04-29 14:59 ` mancha security
2015-04-29 16:40 ` Pranith Kumar
2015-04-29 16:59 ` Daniel Borkmann [this message]
2015-04-29 17:17 ` Pranith Kumar
2015-04-30 5:58 ` mancha security
2015-04-29 15:04 ` Daniel Borkmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55410DF6.3090901@iogearbox.net \
--to=daniel@iogearbox.net \
--cc=bobby.prani@gmail.com \
--cc=hpa@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mancha1@zoho.com \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox