From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751889AbbD2Xfk (ORCPT ); Wed, 29 Apr 2015 19:35:40 -0400 Received: from mailout3.samsung.com ([203.254.224.33]:39791 "EHLO mailout3.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751379AbbD2Xfh (ORCPT ); Wed, 29 Apr 2015 19:35:37 -0400 X-AuditID: cbfee691-f79ca6d00000456a-3f-55416ac6de5d Message-id: <55416AC6.4070403@samsung.com> Date: Thu, 30 Apr 2015 08:35:34 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Richard Fitzgerald Cc: lee.jones@linaro.org, broonie@kernel.org, linus.walleij@linaro.org, gnurou@gmail.com, myungjoo.ham@samsung.com, devicetree@vger.kernel.org, alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, ckeepax@opensource.wolfsonmicro.com Subject: Re: [PATCH v2 6/8] extcon: arizona: Add support for WM8998 and WM1814 References: <1430318229-28518-1-git-send-email-rf@opensource.wolfsonmicro.com> <1430318229-28518-7-git-send-email-rf@opensource.wolfsonmicro.com> In-reply-to: <1430318229-28518-7-git-send-email-rf@opensource.wolfsonmicro.com> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFjrOIsWRmVeSWpSXmKPExsWyRsSkWPdYlmOoQc9MA4srFw8xWUx9+ITN 4t+UG+wW84+cY7U49+oRi8X9r0cZLab8Wc5ksXn+H0aLy7vmsFncblzBZrH87X82i1kT/7A4 8Hhs+NzE5rFz1l12j02rOtk87lzbw+bxcuJvNo++LasYPT5vkgtgj+KySUnNySxLLdK3S+DK 6FpzgKVgmmjFooN32BoYlwp0MXJwSAiYSLxo0exi5AQyxSQu3FvP1sXIxSEksJRR4sTPi6wQ CROJz2+PMkMkFjFK7G99CFX1gFFizoN1rCCTeAW0JJbvrgdpYBFQlXi3aCojiM0GFN7/4gYb iC0qECaxcvoVFhCbV0BQ4sfke2C2iIC5xOKbd1hBZjILbGeS+PdkGhNIQljAT2Jy9xWozZMZ JfZ9fs8OkuAU8JdYcKMPbAOzgA7QRdPYIGx5ic1r3oI1SAh0ckisnn2eGeIkAYlvkw+xQPws K7HpADPEa5ISB1fcYJnAKDYLyVGzkIydhWTsAkbmVYyiqQXJBcVJ6UWmesWJucWleel6yfm5 mxiB8Xv637OJOxjvH7A+xCjAwajEwyuo6xAqxJpYVlyZe4jRFOiKicxSosn5wCSRVxJvaGxm ZGFqYmpsZG5ppiTOqyP9M1hIID2xJDU7NbUgtSi+qDQntfgQIxMHp1QDo4LfjrqYcyv2X2vv NveaXHuswXt5c6Vf45X212vzo3Nrhb5diZm8fMnE0umx6p2MZxT1v07kdH525FvTxE+ay7vt GfY6hIgZL+t6xvtkU2jmipUenbWzVnQLmLAuzdcW/HwoJ+CKzeaa3bulzmbd+mplNL3m4JeJ Fvyrq+OdsrY1CSb3GCztUWIpzkg01GIuKk4EAGIspAraAgAA X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprEKsWRmVeSWpSXmKPExsVy+t9jAd1jWY6hBgs6tCyuXDzEZDH14RM2 i39TbrBbzD9yjtXi3KtHLBb3vx5ltJjyZzmTxeb5fxgtLu+aw2Zxu3EFm8Xyt//ZLGZN/MPi wOOx4XMTm8fOWXfZPTat6mTzuHNtD5vHy4m/2Tz6tqxi9Pi8SS6APaqB0SYjNTEltUghNS85 PyUzL91WyTs43jne1MzAUNfQ0sJcSSEvMTfVVsnFJ0DXLTMH6FQlhbLEnFKgUEBicbGSvh2m CaEhbroWMI0Rur4hQXA9RgZoIGENY0bXmgMsBdNEKxYdvMPWwLhUoIuRk0NCwETi89ujzBC2 mMSFe+vZuhi5OIQEFjFK7G99COU8YJSY82AdaxcjBwevgJbE8t31IA0sAqoS7xZNZQSx2YDC +1/cYAOxRQXCJFZOv8ICYvMKCEr8mHwPzBYRMJdYfPMOK8hMZoHtTBL/nkxjAkkIC/hJTO6+ wgyxbDKjxL7P79lBEpwC/hILbvSBbWAW0AG6aBobhC0vsXnNW+YJjAKzkCyZhaRsFpKyBYzM qxhFUwuSC4qT0nON9IoTc4tL89L1kvNzNzGC08Mz6R2MqxosDjEKcDAq8fAK6DqECrEmlhVX 5h5ilOBgVhLhfZ7sGCrEm5JYWZValB9fVJqTWnyI0RQYBhOZpUST84GpK68k3tDYxMzI0sjc 0MLI2FxJnHeOrlyokEB6YklqdmpqQWoRTB8TB6dUA2OPRlaF9tFNiosj171tLvFYuewId0yr ntf6cvmnPyqOM8cctv/dYxke0vzx/qMl9X1zHx6+/cSWq3j7PtfwJQvl/JdOcRWtrewxnT2X oT2uW1Bomv/dl75HT6nnGChr3Xw909i2Y8Vl+Uknhas++YW22G1+5+/CHv8sZ8qKz7ErF0Ro vzKrbFdiKc5INNRiLipOBAC+n0/tJQMAAA== DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Richard, This patch didn't include any description? I think that you better to add the patch description. Thanks, Chanwoo Choi On 04/29/2015 11:37 PM, Richard Fitzgerald wrote: > Signed-off-by: Richard Fitzgerald > Acked-by: Chanwoo Choi > --- > drivers/extcon/extcon-arizona.c | 33 ++++++++++++++++++++++----------- > 1 files changed, 22 insertions(+), 11 deletions(-) > > diff --git a/drivers/extcon/extcon-arizona.c b/drivers/extcon/extcon-arizona.c > index 830c5f9..586ec53 100644 > --- a/drivers/extcon/extcon-arizona.c > +++ b/drivers/extcon/extcon-arizona.c > @@ -1,7 +1,7 @@ > /* > * extcon-arizona.c - Extcon driver Wolfson Arizona devices > * > - * Copyright (C) 2012 Wolfson Microelectronics plc > + * Copyright (C) 2012-2014 Wolfson Microelectronics plc > * > * This program is free software; you can redistribute it and/or modify > * it under the terms of the GNU General Public License as published by > @@ -140,10 +140,14 @@ static void arizona_extcon_hp_clamp(struct arizona_extcon_info *info, > bool clamp) > { > struct arizona *arizona = info->arizona; > - unsigned int mask = 0, val = 0; > + unsigned int mask, val = 0; > int ret; > > switch (arizona->type) { > + case WM8998: > + case WM1814: > + mask = 0; > + break; > case WM5110: > mask = ARIZONA_HP1L_SHRTO | ARIZONA_HP1L_FLWR | > ARIZONA_HP1L_SHRTI; > @@ -175,17 +179,19 @@ static void arizona_extcon_hp_clamp(struct arizona_extcon_info *info, > ret); > } > > - ret = regmap_update_bits(arizona->regmap, ARIZONA_HP_CTRL_1L, > - mask, val); > - if (ret != 0) > - dev_warn(arizona->dev, "Failed to do clamp: %d\n", > + if (mask) { > + ret = regmap_update_bits(arizona->regmap, ARIZONA_HP_CTRL_1L, > + mask, val); > + if (ret != 0) > + dev_warn(arizona->dev, "Failed to do clamp: %d\n", > ret); > > - ret = regmap_update_bits(arizona->regmap, ARIZONA_HP_CTRL_1R, > - mask, val); > - if (ret != 0) > - dev_warn(arizona->dev, "Failed to do clamp: %d\n", > - ret); > + ret = regmap_update_bits(arizona->regmap, ARIZONA_HP_CTRL_1R, > + mask, val); > + if (ret != 0) > + dev_warn(arizona->dev, "Failed to do clamp: %d\n", > + ret); > + } > > /* Restore the desired state while not doing the clamp */ > if (!clamp) { > @@ -1176,6 +1182,11 @@ static int arizona_extcon_probe(struct platform_device *pdev) > break; > } > break; > + case WM8998: > + case WM1814: > + info->micd_clamp = true; > + info->hpdet_ip_version = 2; > + break; > default: > break; > } >