Re: [lm-sensors][PATCH] hwmon: (ntc_thermistor) Add support for ncpXXwf104

[Guenter Roeck <linux@roeck-us.net>]

On 04/29/2015 07:25 PM, Beomho Seo wrote:
> This patch adds support for the ntc thermistor NCPXXWF104 serise.
>
s/serise/series

> Cc: Jean Delvare <jdelvare@suse.de>
> Cc: Guenter Roeck <linux@roeck-us.net>
> Signed-off-by: Beomho Seo <beomho.seo@samsung.com>
> ---
>   drivers/hwmon/ntc_thermistor.c               |   45 ++++++++++++++++++++++++++
>   include/linux/platform_data/ntc_thermistor.h |    1 +

Please also update
	Documentation/devicetree/bindings/hwmon/ntc_thermistor.txt
	Documentation/hwmon/ntc_thermistor
	drivers/hwmon/Kconfig

>   2 files changed, 46 insertions(+)
>
> diff --git a/drivers/hwmon/ntc_thermistor.c b/drivers/hwmon/ntc_thermistor.c
> index 112e4d4..a320664 100644
> --- a/drivers/hwmon/ntc_thermistor.c
> +++ b/drivers/hwmon/ntc_thermistor.c
> @@ -53,6 +53,7 @@ static const struct platform_device_id ntc_thermistor_id[] = {
>   	{ "ncp03wb473", TYPE_NCPXXWB473 },
>   	{ "ncp15wl333", TYPE_NCPXXWL333 },
>   	{ "b57330v2103", TYPE_B57330V2103},
> +	{ "ncp03wf104", TYPE_NCPXXWF104 },
>   	{ },
>   };
>
> @@ -135,6 +136,43 @@ static const struct ntc_compensation ncpXXwl333[] = {
>   	{ .temp_c	= 125, .ohm	= 707 },
>   };
>
> +static const struct ntc_compensation ncpXXwf104[] = {
> +	{ .temp_c	= -40, .ohm	= 4397119 },
> +	{ .temp_c	= -35, .ohm	= 3088599 },
> +	{ .temp_c	= -30, .ohm	= 2197225 },
> +	{ .temp_c	= -25, .ohm	= 1581881 },
> +	{ .temp_c	= -20, .ohm	= 1151037 },
> +	{ .temp_c	= -15, .ohm	= 846579 },
> +	{ .temp_c	= -10, .ohm	= 628988 },
> +	{ .temp_c	= -5, .ohm	= 471632 },
> +	{ .temp_c	= 0, .ohm	= 357012 },
> +	{ .temp_c	= 5, .ohm	= 272500 },
> +	{ .temp_c	= 10, .ohm	= 209710 },
> +	{ .temp_c	= 15, .ohm	= 162651 },
> +	{ .temp_c	= 20, .ohm	= 127080 },
> +	{ .temp_c	= 25, .ohm	= 100000 },
> +	{ .temp_c	= 30, .ohm	= 79222 },
> +	{ .temp_c	= 35, .ohm	= 63167 },
> +	{ .temp_c	= 40, .ohm	= 50677 },
> +	{ .temp_c	= 45, .ohm	= 40904 },
> +	{ .temp_c	= 50, .ohm	= 33195 },
> +	{ .temp_c	= 55, .ohm	= 27091 },
> +	{ .temp_c	= 60, .ohm	= 22224 },
> +	{ .temp_c	= 65, .ohm	= 18323 },
> +	{ .temp_c	= 70, .ohm	= 15184 },
> +	{ .temp_c	= 75, .ohm	= 12635 },
> +	{ .temp_c	= 80, .ohm	= 10566 },
> +	{ .temp_c	= 85, .ohm	= 8873 },
> +	{ .temp_c	= 90, .ohm	= 7481 },
> +	{ .temp_c	= 95, .ohm	= 6337 },
> +	{ .temp_c	= 100, .ohm	= 5384 },
> +	{ .temp_c	= 105, .ohm	= 4594 },
> +	{ .temp_c	= 110, .ohm	= 3934 },
> +	{ .temp_c	= 115, .ohm	= 3380 },
> +	{ .temp_c	= 120, .ohm	= 2916 },
> +	{ .temp_c	= 125, .ohm	= 2522 },
> +};
> +
>   /*
>    * The following compensation table is from the specification of EPCOS NTC
>    * Thermistors Datasheet
> @@ -231,6 +269,9 @@ static const struct of_device_id ntc_match[] = {
>   		.data = &ntc_thermistor_id[3] },
>   	{ .compatible = "ntc,ncp15wl333",
>   		.data = &ntc_thermistor_id[4] },
> +	{ .compatible = "ntc,ncp03wf104",

Please use murata instead of ntc (see the devicetree bindings document),
and add the entry to the murata list.

> +		.data = &ntc_thermistor_id[6] },
> +
>   	{ },
>   };
>   MODULE_DEVICE_TABLE(of, ntc_match);
> @@ -558,6 +599,10 @@ static int ntc_thermistor_probe(struct platform_device *pdev)
>   		data->comp = b57330v2103;
>   		data->n_comp = ARRAY_SIZE(b57330v2103);
>   		break;
> +	case TYPE_NCPXXWF104:
> +		data->comp = ncpXXwf104;
> +		data->n_comp = ARRAY_SIZE(ncpXXwf104);
> +		break;
>   	default:
>   		dev_err(&pdev->dev, "Unknown device type: %lu(%s)\n",
>   				pdev_id->driver_data, pdev_id->name);
> diff --git a/include/linux/platform_data/ntc_thermistor.h b/include/linux/platform_data/ntc_thermistor.h
> index 0a6de4c..aed1705 100644
> --- a/include/linux/platform_data/ntc_thermistor.h
> +++ b/include/linux/platform_data/ntc_thermistor.h
> @@ -27,6 +27,7 @@ enum ntc_thermistor_type {
>   	TYPE_NCPXXWB473,
>   	TYPE_NCPXXWL333,
>   	TYPE_B57330V2103,
> +	TYPE_NCPXXWF104,
>   };
>
>   struct ntc_thermistor_platform_data {
>