From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1750895AbbD3Hjh (ORCPT ); Thu, 30 Apr 2015 03:39:37 -0400 Received: from mailout4.samsung.com ([203.254.224.34]:54763 "EHLO mailout4.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750730AbbD3Hje (ORCPT ); Thu, 30 Apr 2015 03:39:34 -0400 X-AuditID: cbfee690-f796f6d000005054-7b-5541dc33be9e Message-id: <5541DC33.80400@samsung.com> Date: Thu, 30 Apr 2015 16:39:31 +0900 From: Chanwoo Choi User-Agent: Mozilla/5.0 (X11; Linux i686; rv:17.0) Gecko/20130106 Thunderbird/17.0.2 MIME-version: 1.0 To: Ramakrishna Pallala , Lee Jones Cc: linux-kernel@vger.kernel.org, Samuel Ortiz , Jacob Pan Subject: Re: [PATCH v9] extcon-axp288: Add axp288 extcon driver support References: <1430406885-17973-1-git-send-email-ramakrishna.pallala@intel.com> In-reply-to: <1430406885-17973-1-git-send-email-ramakrishna.pallala@intel.com> Content-type: text/plain; charset=ISO-8859-1 Content-transfer-encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprAIsWRmVeSWpSXmKPExsWyRsSkUNf4jmOowY8F5hZLD65nsbj/9Sij xeVdc9gsFr65yWRxupvVgdVj8Z6XTB53ru1h85h3MtDj8ya5AJYoLpuU1JzMstQifbsEroyb lyYwF1zirbi/7gd7A+Mdri5GDg4JAROJRwtquhg5gUwxiQv31rOB2EICSxkl/p5KhYibSCza cYe1i5ELKL6IUeL5yUOMEM4DRokV36YwgVTxCmhIvJt7GaybRUBVYu7LZlYQm01AS2L/ixtg cVGBMImV06+wQNQLSvyYfA/MFhGIlri4aDmYzSxQLDH1UzcjiC0s4C6x+EAjO8ihQgK+ErM7 y0HCnAJ+EttuLmGHKNeR2N86jQ3ClpfYvOYtM8htEgKb2CW+PLjFCnGPgMS3yYdYIB6Wldh0 gBniMUmJgytusExgFJuF5KJZSMbOQjJ2ASPzKkbR1ILkguKk9CITveLE3OLSvHS95PzcTYzA iDr979mEHYz3DlgfYhTgYFTi4f3Q7hgqxJpYVlyZe4jRFOiKicxSosn5wLjNK4k3NDYzsjA1 MTU2Mrc0UxLnfS31M1hIID2xJDU7NbUgtSi+qDQntfgQIxMHp1QD4xTR3cIa4gnLjpV/nxR1 4+1257LF+wTTcjXb7Rf9WmDc8192p00H40WBH1dOT/mqZiO8f+GPs3uTNT183QLmxhjOV/mm f/Kc0/0zTx3dviy9MOvY7T3X85asWr5if+OEz1d0cjQnr3pfrxah4n+S6e+G1ZGZQbde5LY3 fgg4svzjSaZZk5nfqeYpsRRnJBpqMRcVJwIATXLFGaMCAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFrrDIsWRmVeSWpSXmKPExsVy+t9jAV3jO46hBmd+GFgsPbiexeL+16OM Fpd3zWGzWPjmJpPF6W5WB1aPxXteMnncubaHzWPeyUCPz5vkAliiGhhtMlITU1KLFFLzkvNT MvPSbZW8g+Od403NDAx1DS0tzJUU8hJzU22VXHwCdN0yc4DWKimUJeaUAoUCEouLlfTtME0I DXHTtYBpjND1DQmC6zEyQAMJaxgzbl6awFxwibfi/rof7A2Md7i6GDk5JARMJBbtuMMKYYtJ XLi3nq2LkYtDSGARo8Tzk4cYIZwHjBIrvk1hAqniFdCQeDf3MhuIzSKgKjH3ZTNYN5uAlsT+ FzfA4qICYRIrp19hgagXlPgx+R6YLSIQLXFx0XIwm1mgWGLqp25GEFtYwF1i8YFG9i5GDqBl vhKzO8tBwpwCfhLbbi5hhyjXkdjfOo0NwpaX2LzmLfMERoFZSDbMQlI2C0nZAkbmVYyiqQXJ BcVJ6blGesWJucWleel6yfm5mxjBMftMegfjqgaLQ4wCHIxKPLwf2h1DhVgTy4orcw8xSnAw K4nwdtwCCvGmJFZWpRblxxeV5qQWH2I0BQbARGYp0eR8YDrJK4k3NDYxM7I0Mje0MDI2VxLn naMrFyokkJ5YkpqdmlqQWgTTx8TBKdXAuDDbzNOcrYdl/WLleHfFDU+0xLVzpqe15jV/8zMJ ORiVb/N5wrcfbRZZe2Y1yy9dsNw+W28279tPs1OW+H4+0rfolXD4x6DaoM2Tbj//cWX1Eu9F Wfwls2M3rL+WtT90yyFlrxsX3NbM401ZnLxAb3Wz3cMb0SeWBGzoyU5Jn56go2n0a+OSGiWW 4oxEQy3mouJEAPDKrovvAgAA DLP-Filter: Pass X-MTR: 20000000000000000@CPGS X-CFilter-Loop: Reflected Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Ram, This patch has still one minor issue on below comment. But I fix it and will apply it on extcon-next branch after discussing how to apply this patch with Lee Jones (MFD maintainer). Dear Lee, Do you want to send pull request after I make the immutable branch for this patch? or apply this patch on extcon git without any pull request? Thanks, Chanwoo Choi On 05/01/2015 12:14 AM, Ramakrishna Pallala wrote: > This patch adds the extcon support for AXP288 PMIC which > has the BC1.2 charger detection capability. Additionally > it also adds the USB mux switching support b/w SOC and PMIC > based on GPIO control. > > Signed-off-by: Ramakrishna Pallala > Acked-by: Lee Jones > --- > drivers/extcon/Kconfig | 7 + > drivers/extcon/Makefile | 1 + > drivers/extcon/extcon-axp288.c | 385 ++++++++++++++++++++++++++++++++++++++++ > include/linux/mfd/axp20x.h | 5 + > 4 files changed, 398 insertions(+) > create mode 100644 drivers/extcon/extcon-axp288.c > [snip] > + vbus_attach ? EXTCON_GPIO_MUX_SEL_SOC > + : EXTCON_GPIO_MUX_SEL_PMIC); > + > + atomic_notifier_call_chain(&info->otg->notifier, > + vbus_attach ? USB_EVENT_VBUS : USB_EVENT_NONE, NULL); > + } > + > + if (notify_charger) > + extcon_set_cable_state(info->edev, cable, vbus_attach); > + > + /* Clear the flags on disconnect event */ > + if (!vbus_attach) > + notify_otg = notify_charger = false; > + > + return 0; > + > +dev_det_ret: > + if (ret < 0) > + dev_err(info->dev, "BC Mod detection error\n"); You miss the fix about following comment. "BC Mod detection error\n" -> "failed to detect BC Mod\n" [snip]