From: David Howells <dhowells@redhat.com>
To: Namhyung Kim <namhyung@gmail.com>
Cc: dhowells@redhat.com, Roland McGrath <roland@redhat.com>,
Oleg Nesterov <oleg@redhat.com>, Arnd Bergmann <arnd@arndb.de>,
linux-kernel@vger.kernel.org
Subject: Re: [RFC PATCH 14/43] ptrace, frv: change signature of arch_ptrace()
Date: Fri, 27 Aug 2010 13:12:03 +0100 [thread overview]
Message-ID: <5542.1282911123@redhat.com> (raw)
In-Reply-To: <87aao8gvbm.fsf@NHK-XNOTE.i-did-not-set--mail-host-address--so-tickle-me>
Namhyung Kim <namhyung@gmail.com> wrote:
> > That description means nothing. Commit
> > f76671df26ef06321480e702770f88f61272be29 is not upstream.
>
> Hi,
> Thank you for noticing. My bad.
The problem with using a non-upstream commit ID like this is that it likely
won't be the same once that commit is committed by Linus.
> I just wanted to let you know it depends on that.
The patch being part of the series is probably sufficient, though a note of
the subject line of the previous patch would be useful.
> What is the proper way to handle this?
A summary of the changes being made is good:
ptrace: Fix up the arguments arch_ptrace() in arch FRV
Fix up the arguments to arch_ptrace() to take account of the fact that
addr and data are now unsigned long rather than long as of a preceding
patch in this series.
Signed-off-by: ...
Note, however, that if the earlier patch breaks the compilation and then this
patch fixes it up, you should roll this patch into the earlier patch, and the
earlier patch is not complete without it.
Think what happens if patch 3/43 breaks an arch, and then patch 43/43, say,
mends that arch, and then bisection lands on patch 3 during its progress. You
may end up having to 'git bisect skip' all the patches between 3 and 43 one at
a time.
David
next prev parent reply other threads:[~2010-08-27 12:12 UTC|newest]
Thread overview: 62+ messages / expand[flat|nested] mbox.gz Atom feed top
2010-08-27 9:41 [RFC PATCH 00/43] ptrace cleanups Namhyung Kim
2010-08-27 9:41 ` [RFC PATCH 01/43] ptrace: change signature of sys_ptrace() and friends Namhyung Kim
2010-08-27 13:21 ` Arnd Bergmann
2010-08-27 15:55 ` Namhyung Kim
2010-08-27 9:41 ` [RFC PATCH 02/43] ptrace: cleanup ptrace_request() Namhyung Kim
2010-08-27 14:23 ` Arnd Bergmann
2010-08-27 16:13 ` Namhyung Kim
2010-08-27 19:26 ` Arnd Bergmann
2010-08-27 9:41 ` [RFC PATCH 03/43] ptrace: change signature of arch_ptrace() Namhyung Kim
2010-08-27 14:28 ` Arnd Bergmann
2010-08-27 16:20 ` Namhyung Kim
2010-08-29 13:40 ` Arnd Bergmann
2010-08-27 9:41 ` [RFC PATCH 04/43] ptrace, x86: " Namhyung Kim
2010-08-27 9:41 ` [RFC PATCH 05/43] ptrace, x86: cleanup arch_ptrace() Namhyung Kim
2010-08-27 9:41 ` [RFC PATCH 06/43] ptrace, alpha: change signature of arch_ptrace() Namhyung Kim
2010-08-27 9:41 ` [RFC PATCH 07/43] ptrace, arm: " Namhyung Kim
2010-08-27 9:41 ` [RFC PATCH 08/43] ptrace, arm: cleanup arch_ptrace() Namhyung Kim
2010-08-27 9:41 ` [RFC PATCH 09/43] ptrace, avr32: change signature of arch_ptrace() Namhyung Kim
2010-08-27 9:41 ` [RFC PATCH 10/43] ptrace, avr32: cleanup arch_ptrace() Namhyung Kim
2010-08-30 12:34 ` Haavard Skinnemoen
2010-08-27 9:41 ` [RFC PATCH 11/43] ptrace, blackfin: change signature of arch_ptrace() Namhyung Kim
2010-08-27 9:41 ` [RFC PATCH 12/43] ptrace, cris-v10: " Namhyung Kim
2010-08-27 9:41 ` [RFC PATCH 13/43] ptrace, cris-v32: " Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 14/43] ptrace, frv: " Namhyung Kim
2010-08-27 11:01 ` David Howells
2010-08-27 11:15 ` Namhyung Kim
2010-08-27 12:12 ` David Howells [this message]
2010-08-27 12:58 ` Namhyung Kim
2010-08-27 13:23 ` David Howells
2010-08-27 15:53 ` Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 15/43] ptrace, frv: cleanup arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 16/43] ptrace, h8300: change signature of arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 17/43] ptrace, h8300: cleanup arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 18/43] ptrace, ia64: change signature of arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 19/43] ptrace, m32r: " Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 20/43] ptrace, m32r: cleanup arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 21/43] ptrace, m68k: change signature of arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 22/43] ptrace, m68k: cleanup arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 23/43] ptrace, m68knommu: change signature of arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 24/43] ptrace, m68knommu: cleanup arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 25/43] ptrace, microblaze: change signature of arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 26/43] ptrace, mips: " Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 27/43] ptrace, mips: cleanup arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 28/43] ptrace, mn10300: change signature of arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 29/43] ptrace, mn10300: cleanup arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 30/43] ptrace, parisc: change signature of arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 31/43] ptrace, powerpc: " Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 32/43] ptrace, powerpc: cleanup arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 33/43] ptrace, s390: change signature of arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 34/43] ptrace, score: " Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 35/43] ptrace, sh: " Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 36/43] ptrace, sh: cleanup arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 37/43] ptrace, sparc: change signature of arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 38/43] ptrace, sparc: cleanup arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 39/43] ptrace, tile: change signature of arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 40/43] ptrace, um: " Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 41/43] ptrace, um: cleanup arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 42/43] ptrace, xtensa: change signature of arch_ptrace() Namhyung Kim
2010-08-27 9:42 ` [RFC PATCH 43/43] ptrace, xtensa: cleanup arch_ptrace() Namhyung Kim
2010-08-27 16:30 ` [RFC PATCH 00/43] ptrace cleanups Mike Frysinger
2010-08-30 0:14 ` Roland McGrath
2010-08-30 14:02 ` Namhyung Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5542.1282911123@redhat.com \
--to=dhowells@redhat.com \
--cc=arnd@arndb.de \
--cc=linux-kernel@vger.kernel.org \
--cc=namhyung@gmail.com \
--cc=oleg@redhat.com \
--cc=roland@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox