From: Christian Borntraeger <borntraeger@de.ibm.com>
To: Preeti U Murthy <preeti@linux.vnet.ibm.com>
Cc: peterz@infradead.org, paulmck@linux.vnet.ibm.com,
dave@stgolabs.net, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] kernel: Replace reference to ASSIGN_ONCE with WRITE_ONCE in comment
Date: Thu, 30 Apr 2015 14:09:18 +0200 [thread overview]
Message-ID: <55421B6E.4050103@de.ibm.com> (raw)
In-Reply-To: <20150430115721.22278.94082.stgit@preeti.in.ibm.com>
Am 30.04.2015 um 13:57 schrieb Preeti U Murthy:
> Looks like commit :
>
> 43239cbe79fc ("kernel: Change ASSIGN_ONCE(val, x) to WRITE_ONCE(x, val)")
>
> left behind a reference to ASSIGN_ONCE. Update this to WRITE_ONCE.
>
> Signed-off-by: Preeti U Murthy <preeti@linux.vnet.ibm.com>
Acked-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
>
> include/linux/compiler.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/compiler.h b/include/linux/compiler.h
> index 0e41ca0..e65e0a7 100644
> --- a/include/linux/compiler.h
> +++ b/include/linux/compiler.h
> @@ -446,7 +446,7 @@ static __always_inline void __write_once_size(volatile void *p, void *res, int s
> * with an explicit memory barrier or atomic instruction that provides the
> * required ordering.
> *
> - * If possible use READ_ONCE/ASSIGN_ONCE instead.
> + * If possible use READ_ONCE/WRITE_ONCE instead.
> */
> #define __ACCESS_ONCE(x) ({ \
> __maybe_unused typeof(x) __var = (__force typeof(x)) 0; \
>
next prev parent reply other threads:[~2015-04-30 12:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 11:57 [PATCH] kernel: Replace reference to ASSIGN_ONCE with WRITE_ONCE in comment Preeti U Murthy
2015-04-30 12:09 ` Christian Borntraeger [this message]
2015-05-08 13:25 ` [tip:locking/core] kernel: Replace reference to ASSIGN_ONCE() with WRITE_ONCE() " tip-bot for Preeti U Murthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=55421B6E.4050103@de.ibm.com \
--to=borntraeger@de.ibm.com \
--cc=dave@stgolabs.net \
--cc=linux-kernel@vger.kernel.org \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=preeti@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox