From: Guenter Roeck <linux@roeck-us.net>
To: Bartosz Golaszewski <bgolaszewski@baylibre.com>,
LKML <linux-kernel@vger.kernel.org>
Cc: Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Viresh Kumar <viresh.kumar@linaro.org>,
Jean Delvare <jdelvare@suse.de>,
Fenghua Yu <fenghua.yu@intel.com>,
Benoit Cousson <bcousson@baylibre.com>
Subject: Re: [PATCH 1/6] coretemp: replace cpu_sibling_mask() with topology_thread_cpumask()
Date: Thu, 30 Apr 2015 06:10:37 -0700 [thread overview]
Message-ID: <554229CD.8020207@roeck-us.net> (raw)
In-Reply-To: <1430388241-4502-2-git-send-email-bgolaszewski@baylibre.com>
On 04/30/2015 03:03 AM, Bartosz Golaszewski wrote:
> The former duplicates the functionality of the latter but is neither
> documented nor arch-independent.
>
> Signed-off-by: Bartosz Golaszewski <bgolaszewski@baylibre.com>
Acked-by: Guenter Roeck <linux@roeck-us.net>
> ---
> drivers/hwmon/coretemp.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/hwmon/coretemp.c b/drivers/hwmon/coretemp.c
> index ed303ba..f9b65f9 100644
> --- a/drivers/hwmon/coretemp.c
> +++ b/drivers/hwmon/coretemp.c
> @@ -63,7 +63,8 @@ MODULE_PARM_DESC(tjmax, "TjMax value in degrees Celsius");
> #define TO_ATTR_NO(cpu) (TO_CORE_ID(cpu) + BASE_SYSFS_ATTR_NO)
>
> #ifdef CONFIG_SMP
> -#define for_each_sibling(i, cpu) for_each_cpu(i, cpu_sibling_mask(cpu))
> +#define for_each_sibling(i, cpu) \
> + for_each_cpu(i, topology_thread_cpumask(cpu))
> #else
> #define for_each_sibling(i, cpu) for (i = 0; false; )
> #endif
>
next prev parent reply other threads:[~2015-04-30 13:12 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-30 10:03 [PATCH 0/6] x86: remove cpu_**_mask() functions Bartosz Golaszewski
2015-04-30 10:03 ` [PATCH 1/6] coretemp: replace cpu_sibling_mask() with topology_thread_cpumask() Bartosz Golaszewski
2015-04-30 13:10 ` Guenter Roeck [this message]
2015-04-30 10:03 ` [PATCH 2/6] powernow-k8: replace cpu_core_mask() with topology_core_cpumask() Bartosz Golaszewski
2015-04-30 10:03 ` [PATCH 3/6] p4-clockmod: replace cpu_sibling_mask() with topology_thread_cpumask() Bartosz Golaszewski
2015-04-30 10:03 ` [PATCH 4/6] acpi-cpufreq: replace cpu_**_mask() with topology_**_cpumask() Bartosz Golaszewski
2015-04-30 10:04 ` [PATCH 5/6] x86: " Bartosz Golaszewski
2015-05-02 6:33 ` Ingo Molnar
2015-05-04 8:23 ` Bartosz Golaszewski
2015-04-30 10:04 ` [PATCH 6/6] x86: remove cpu_sibling_mask() and cpu_core_mask() Bartosz Golaszewski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=554229CD.8020207@roeck-us.net \
--to=linux@roeck-us.net \
--cc=bcousson@baylibre.com \
--cc=bgolaszewski@baylibre.com \
--cc=fenghua.yu@intel.com \
--cc=hpa@zytor.com \
--cc=jdelvare@suse.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=rjw@rjwysocki.net \
--cc=tglx@linutronix.de \
--cc=viresh.kumar@linaro.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox