Re: [PATCH] drm: panel: simple-panel: set appropriate mode type

[Nicolas Ferre <nicolas.ferre@atmel.com>]

Le 30/04/2015 16:39, Boris Brezillon a écrit :
> All modes exposed by simple panels should be tagged as driver defined
> modes.
> Moreover, if a panel supports only one mode, this mode is obviously the
> preferred one.
> 
> Doing this also fix a problem occurring when a 'video=' parameter is passed
> on the kernel cmdline. In some cases the user provided mode is preferred
> over the simple panel ones, which might result in unpredictable behavior.
> 
> Signed-off-by: Boris Brezillon <boris.brezillon@free-electrons.com>

Tested-by: Nicolas Ferre <nicolas.ferre@atmel.com>
On Atmel sama5d3xek board.

> ---
>  drivers/gpu/drm/panel/panel-simple.c | 8 ++++++++
>  1 file changed, 8 insertions(+)
> 
> diff --git a/drivers/gpu/drm/panel/panel-simple.c b/drivers/gpu/drm/panel/panel-simple.c
> index d14b904..95ae390 100644
> --- a/drivers/gpu/drm/panel/panel-simple.c
> +++ b/drivers/gpu/drm/panel/panel-simple.c
> @@ -111,6 +111,10 @@ static int panel_simple_get_fixed_modes(struct panel_simple *panel)
>  			continue;
>  		}
>  
> +		mode->type |= DRM_MODE_TYPE_DRIVER;
> +		if (panel->desc->num_modes == 1)
> +			mode->type |= DRM_MODE_TYPE_PREFERRED;
> +
>  		drm_display_mode_from_videomode(&vm, mode);
>  
>  		drm_mode_probed_add(connector, mode);
> @@ -127,6 +131,10 @@ static int panel_simple_get_fixed_modes(struct panel_simple *panel)
>  			continue;
>  		}
>  
> +		mode->type |= DRM_MODE_TYPE_DRIVER;
> +		if (panel->desc->num_modes == 1)
> +			mode->type |= DRM_MODE_TYPE_PREFERRED;
> +
>  		drm_mode_set_name(mode);
>  
>  		drm_mode_probed_add(connector, mode);
> 


-- 
Nicolas Ferre