From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753008AbbD3UKL (ORCPT ); Thu, 30 Apr 2015 16:10:11 -0400 Received: from mail-am1on0065.outbound.protection.outlook.com ([157.56.112.65]:5968 "EHLO emea01-am1-obe.outbound.protection.outlook.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1752428AbbD3UKI (ORCPT ); Thu, 30 Apr 2015 16:10:08 -0400 Authentication-Results: infradead.org; dkim=none (message not signed) header.d=none; Message-ID: <55428C10.4070904@ezchip.com> Date: Thu, 30 Apr 2015 16:09:52 -0400 From: Chris Metcalf User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Don Zickus CC: Frederic Weisbecker , Ingo Molnar , Andrew Morton , Andrew Jones , chai wen , Ulrich Obergfell , Fabian Frederick , Aaron Tomlin , Ben Zhang , Christoph Lameter , Gilad Ben-Yossef , Steven Rostedt , , Jonathan Corbet , , Thomas Gleixner , Peter Zijlstra Subject: Re: [PATCH v10 2/3] watchdog: add watchdog_cpumask sysctl to assist nohz References: <1430422766-19703-1-git-send-email-cmetcalf@ezchip.com> <1430422766-19703-3-git-send-email-cmetcalf@ezchip.com> <20150430200036.GF98296@redhat.com> In-Reply-To: <20150430200036.GF98296@redhat.com> Content-Type: text/plain; charset="windows-1252"; format=flowed Content-Transfer-Encoding: 7bit X-Originating-IP: [12.216.194.146] X-ClientProxiedBy: BN1PR12CA0022.namprd12.prod.outlook.com (25.160.77.32) To VI1PR02MB0783.eurprd02.prod.outlook.com (25.162.14.145) X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:;SRVR:VI1PR02MB0783; X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(601004)(5005006)(3002001);SRVR:VI1PR02MB0783;BCL:0;PCL:0;RULEID:;SRVR:VI1PR02MB0783; X-Forefront-PRVS: 056297E276 X-Forefront-Antispam-Report: SFV:NSPM;SFS:(10009020)(6049001)(6009001)(479174004)(377454003)(76104003)(51704005)(51444003)(87976001)(77096005)(2950100001)(66066001)(99136001)(50466002)(47776003)(15975445007)(64126003)(77156002)(23746002)(62966003)(36756003)(86362001)(54356999)(50986999)(87266999)(59896002)(83506001)(122386002)(65956001)(33656002)(4001350100001)(46102003)(42186005)(19580395003)(76176999)(65806001)(92566002)(40100003)(5001960100002)(110136002)(65816999)(18886065003);DIR:OUT;SFP:1101;SCL:1;SRVR:VI1PR02MB0783;H:[10.7.0.41];FPR:;SPF:None;MLV:sfv;LANG:en; X-OriginatorOrg: ezchip.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 30 Apr 2015 20:10:02.6529 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR02MB0783 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 04/30/2015 04:00 PM, Don Zickus wrote: > On Thu, Apr 30, 2015 at 03:39:25PM -0400, Chris Metcalf wrote: >> if (err) >> pr_err("Failed to create watchdog threads, disabled\n"); >> + else { >> + if (smpboot_update_cpumask_percpu_thread( >> + &watchdog_threads, &watchdog_cpumask)) >> + pr_err("Failed to set cpumask for watchdog threads\n"); > Stupid nitpick, this error message tells us the 'watchdog' threads caused > the cpumask failure, but .... > >> + /* >> + * Failure would be due to being unable to allocate >> + * a temporary cpumask, so we are likely not in a >> + * position to do much else to make things better. >> + */ >> + if (smpboot_update_cpumask_percpu_thread( >> + &watchdog_threads, &watchdog_cpumask) != 0) >> + pr_err("cpumask update failed\n"); > This one does not. :-( If there is a respin, I would suggest copying the > above message down here. There is that "#define pr_fmt(fmt)" at the top of the file that prefixes all the messages with "NMI watchdog: ", though. I think that's sufficient to make it clear what the second message is about. (The first message I wrote the way I did to be parallel with the message just before it, if the thread creation failed.) I could tweak the messages but I think they're reasonable given the prefix. What do you think? -- Chris Metcalf, EZChip Semiconductor http://www.ezchip.com