From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753891AbbEANjN (ORCPT ); Fri, 1 May 2015 09:39:13 -0400 Received: from mail.windriver.com ([147.11.1.11]:57222 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753543AbbEANjL (ORCPT ); Fri, 1 May 2015 09:39:11 -0400 Message-ID: <554381AB.9060205@windriver.com> Date: Fri, 1 May 2015 09:37:47 -0400 From: Paul Gortmaker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: James Bottomley CC: , Vinayak Holikatti , Subject: Re: [PATCH 09/11] drivers/scsi: include for modular ufshcd-pltfrm code References: <1430444867-22342-1-git-send-email-paul.gortmaker@windriver.com> <1430444867-22342-10-git-send-email-paul.gortmaker@windriver.com> <1430447747.4545.3.camel@HansenPartnership.com> In-Reply-To: <1430447747.4545.3.camel@HansenPartnership.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [128.224.56.57] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15-04-30 10:35 PM, James Bottomley wrote: > On Thu, 2015-04-30 at 21:47 -0400, Paul Gortmaker wrote: >> This file is built off of a tristate Kconfig option and also contains >> modular function calls so it should explicitly include module.h to >> avoid compile breakage during header shuffles done in the future. > > I don't understand your logic. The ufs code made a design choice to > consolidate most headers for the hcd code in a local include (ufshcd.h), > which includes module.h, so why would they explicitly need it here as > well? And if we follow your logic, why wouldn't they also need to > duplicate everything else (like the scsi includes)? In my original build testing this file failed to compile once the modular code was moved from init.h to module.h as per the description in the 0/11. Perhaps since that testing something else has changed. I will drop this patch and retest and if it no longer fails, then great. Paul. -- > > James > >