From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753836AbbEANlc (ORCPT ); Fri, 1 May 2015 09:41:32 -0400 Received: from mail.windriver.com ([147.11.1.11]:57574 "EHLO mail.windriver.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752828AbbEANla (ORCPT ); Fri, 1 May 2015 09:41:30 -0400 Message-ID: <55438234.7040205@windriver.com> Date: Fri, 1 May 2015 09:40:04 -0400 From: Paul Gortmaker User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Herbert Xu CC: , "David S. Miller" Subject: Re: [PATCH 01/11] drivers/crypto: include for modular caam code References: <1430444867-22342-1-git-send-email-paul.gortmaker@windriver.com> <1430444867-22342-2-git-send-email-paul.gortmaker@windriver.com> <20150501032404.GC371@gondor.apana.org.au> In-Reply-To: <20150501032404.GC371@gondor.apana.org.au> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [128.224.56.57] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 15-04-30 11:24 PM, Herbert Xu wrote: > On Thu, Apr 30, 2015 at 09:47:37PM -0400, Paul Gortmaker wrote: >> This file is built off of a tristate Kconfig option and also contains >> modular function calls so it should explicitly include module.h to >> avoid compile breakage during header shuffles done in the future. >> >> Cc: Herbert Xu >> Cc: "David S. Miller" >> Signed-off-by: Paul Gortmaker > > Please post patches to linux-crypto@vger.kernel.org if you want them > to go through the crypto tree. Sure, I will add a CC for that in v2 if the patch is needed. > > Also it actually gets module.h through caam/compat.h. So your > patch is unnecessary. Well, in my original build testing this file failed to compile once the modular code was moved from init.h to module.h as per the description in the 0/11. Perhaps since that testing something else has changed. I will drop this patch and retest and if it no longer fails, then great. Thanks, Paul. -- > > Cheers, >