* [PATCH] hw_random: bcm63xx-rng: fix bugs introduced in commit 6229c16060fee9a015bf476f21e40c6f08609d6e.
@ 2015-05-01 14:37 Álvaro Fernández Rojas
2015-05-01 17:27 ` Florian Fainelli
2015-05-02 10:08 ` [PATCH v2] hw_random: bcm63xx-rng: Fix driver compilation Álvaro Fernández Rojas
0 siblings, 2 replies; 4+ messages in thread
From: Álvaro Fernández Rojas @ 2015-05-01 14:37 UTC (permalink / raw)
To: herbert, dmitry.torokhov, linux-crypto, linux-kernel, jogo,
f.fainelli, cernekee
Cc: Álvaro Fernández Rojas
s/clk_didsable_unprepare/clk_disable_unprepare
s/prov/priv
s/error/ret in bcm63xx_rng_probe
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
---
drivers/char/hw_random/bcm63xx-rng.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/char/hw_random/bcm63xx-rng.c b/drivers/char/hw_random/bcm63xx-rng.c
index d1494ec..4b31f13 100644
--- a/drivers/char/hw_random/bcm63xx-rng.c
+++ b/drivers/char/hw_random/bcm63xx-rng.c
@@ -57,7 +57,7 @@ static void bcm63xx_rng_cleanup(struct hwrng *rng)
val &= ~RNG_EN;
__raw_writel(val, priv->regs + RNG_CTRL);
- clk_didsable_unprepare(prov->clk);
+ clk_disable_unprepare(priv->clk);
}
static int bcm63xx_rng_data_present(struct hwrng *rng, int wait)
@@ -97,14 +97,14 @@ static int bcm63xx_rng_probe(struct platform_device *pdev)
priv->rng.name = pdev->name;
priv->rng.init = bcm63xx_rng_init;
priv->rng.cleanup = bcm63xx_rng_cleanup;
- prov->rng.data_present = bcm63xx_rng_data_present;
+ priv->rng.data_present = bcm63xx_rng_data_present;
priv->rng.data_read = bcm63xx_rng_data_read;
priv->clk = devm_clk_get(&pdev->dev, "ipsec");
if (IS_ERR(priv->clk)) {
- error = PTR_ERR(priv->clk);
- dev_err(&pdev->dev, "no clock for device: %d\n", error);
- return error;
+ ret = PTR_ERR(priv->clk);
+ dev_err(&pdev->dev, "no clock for device: %d\n", ret);
+ return ret;
}
if (!devm_request_mem_region(&pdev->dev, r->start,
@@ -120,11 +120,11 @@ static int bcm63xx_rng_probe(struct platform_device *pdev)
return -ENOMEM;
}
- error = devm_hwrng_register(&pdev->dev, &priv->rng);
- if (error) {
+ ret = devm_hwrng_register(&pdev->dev, &priv->rng);
+ if (ret) {
dev_err(&pdev->dev, "failed to register rng device: %d\n",
- error);
- return error;
+ ret);
+ return ret;
}
dev_info(&pdev->dev, "registered RNG driver\n");
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread* Re: [PATCH] hw_random: bcm63xx-rng: fix bugs introduced in commit 6229c16060fee9a015bf476f21e40c6f08609d6e.
2015-05-01 14:37 [PATCH] hw_random: bcm63xx-rng: fix bugs introduced in commit 6229c16060fee9a015bf476f21e40c6f08609d6e Álvaro Fernández Rojas
@ 2015-05-01 17:27 ` Florian Fainelli
2015-05-02 10:08 ` [PATCH v2] hw_random: bcm63xx-rng: Fix driver compilation Álvaro Fernández Rojas
1 sibling, 0 replies; 4+ messages in thread
From: Florian Fainelli @ 2015-05-01 17:27 UTC (permalink / raw)
To: Álvaro Fernández Rojas, herbert, dmitry.torokhov,
linux-crypto, linux-kernel, jogo, cernekee
On 01/05/15 07:37, Álvaro Fernández Rojas wrote:
> s/clk_didsable_unprepare/clk_disable_unprepare
> s/prov/priv
> s/error/ret in bcm63xx_rng_probe
Thanks for fixing that!
Could you resubmit with a "Fixes" tag like this and remove the long
commit id from the subject?
Fixes: 6229c16060fe ("hwrng: bcm63xx - make use of devm_hwrng_register")
Acked-by: Florian Fainelli <f.fainelli@gmail.com>
Even for mechanical devm_* transformations, it would be nice to be CC'd
on the patches ;)
>
> Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
> ---
> drivers/char/hw_random/bcm63xx-rng.c | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
> diff --git a/drivers/char/hw_random/bcm63xx-rng.c b/drivers/char/hw_random/bcm63xx-rng.c
> index d1494ec..4b31f13 100644
> --- a/drivers/char/hw_random/bcm63xx-rng.c
> +++ b/drivers/char/hw_random/bcm63xx-rng.c
> @@ -57,7 +57,7 @@ static void bcm63xx_rng_cleanup(struct hwrng *rng)
> val &= ~RNG_EN;
> __raw_writel(val, priv->regs + RNG_CTRL);
>
> - clk_didsable_unprepare(prov->clk);
> + clk_disable_unprepare(priv->clk);
> }
>
> static int bcm63xx_rng_data_present(struct hwrng *rng, int wait)
> @@ -97,14 +97,14 @@ static int bcm63xx_rng_probe(struct platform_device *pdev)
> priv->rng.name = pdev->name;
> priv->rng.init = bcm63xx_rng_init;
> priv->rng.cleanup = bcm63xx_rng_cleanup;
> - prov->rng.data_present = bcm63xx_rng_data_present;
> + priv->rng.data_present = bcm63xx_rng_data_present;
> priv->rng.data_read = bcm63xx_rng_data_read;
>
> priv->clk = devm_clk_get(&pdev->dev, "ipsec");
> if (IS_ERR(priv->clk)) {
> - error = PTR_ERR(priv->clk);
> - dev_err(&pdev->dev, "no clock for device: %d\n", error);
> - return error;
> + ret = PTR_ERR(priv->clk);
> + dev_err(&pdev->dev, "no clock for device: %d\n", ret);
> + return ret;
> }
>
> if (!devm_request_mem_region(&pdev->dev, r->start,
> @@ -120,11 +120,11 @@ static int bcm63xx_rng_probe(struct platform_device *pdev)
> return -ENOMEM;
> }
>
> - error = devm_hwrng_register(&pdev->dev, &priv->rng);
> - if (error) {
> + ret = devm_hwrng_register(&pdev->dev, &priv->rng);
> + if (ret) {
> dev_err(&pdev->dev, "failed to register rng device: %d\n",
> - error);
> - return error;
> + ret);
> + return ret;
> }
>
> dev_info(&pdev->dev, "registered RNG driver\n");
>
--
Florian
^ permalink raw reply [flat|nested] 4+ messages in thread* [PATCH v2] hw_random: bcm63xx-rng: Fix driver compilation
2015-05-01 14:37 [PATCH] hw_random: bcm63xx-rng: fix bugs introduced in commit 6229c16060fee9a015bf476f21e40c6f08609d6e Álvaro Fernández Rojas
2015-05-01 17:27 ` Florian Fainelli
@ 2015-05-02 10:08 ` Álvaro Fernández Rojas
2015-05-04 9:57 ` Herbert Xu
1 sibling, 1 reply; 4+ messages in thread
From: Álvaro Fernández Rojas @ 2015-05-02 10:08 UTC (permalink / raw)
To: herbert, dmitry.torokhov, linux-crypto, linux-kernel, jogo,
f.fainelli, cernekee
Cc: Álvaro Fernández Rojas
- s/clk_didsable_unprepare/clk_disable_unprepare
- s/prov/priv
- s/error/ret (bcm63xx_rng_probe)
Fixes: 6229c16060fe ("hwrng: bcm63xx - make use of devm_hwrng_register")
Signed-off-by: Álvaro Fernández Rojas <noltari@gmail.com>
---
v2: fix subject, add fixes tag as suggested by Florian
drivers/char/hw_random/bcm63xx-rng.c | 18 +++++++++---------
1 file changed, 9 insertions(+), 9 deletions(-)
diff --git a/drivers/char/hw_random/bcm63xx-rng.c b/drivers/char/hw_random/bcm63xx-rng.c
index d1494ec..4b31f13 100644
--- a/drivers/char/hw_random/bcm63xx-rng.c
+++ b/drivers/char/hw_random/bcm63xx-rng.c
@@ -57,7 +57,7 @@ static void bcm63xx_rng_cleanup(struct hwrng *rng)
val &= ~RNG_EN;
__raw_writel(val, priv->regs + RNG_CTRL);
- clk_didsable_unprepare(prov->clk);
+ clk_disable_unprepare(priv->clk);
}
static int bcm63xx_rng_data_present(struct hwrng *rng, int wait)
@@ -97,14 +97,14 @@ static int bcm63xx_rng_probe(struct platform_device *pdev)
priv->rng.name = pdev->name;
priv->rng.init = bcm63xx_rng_init;
priv->rng.cleanup = bcm63xx_rng_cleanup;
- prov->rng.data_present = bcm63xx_rng_data_present;
+ priv->rng.data_present = bcm63xx_rng_data_present;
priv->rng.data_read = bcm63xx_rng_data_read;
priv->clk = devm_clk_get(&pdev->dev, "ipsec");
if (IS_ERR(priv->clk)) {
- error = PTR_ERR(priv->clk);
- dev_err(&pdev->dev, "no clock for device: %d\n", error);
- return error;
+ ret = PTR_ERR(priv->clk);
+ dev_err(&pdev->dev, "no clock for device: %d\n", ret);
+ return ret;
}
if (!devm_request_mem_region(&pdev->dev, r->start,
@@ -120,11 +120,11 @@ static int bcm63xx_rng_probe(struct platform_device *pdev)
return -ENOMEM;
}
- error = devm_hwrng_register(&pdev->dev, &priv->rng);
- if (error) {
+ ret = devm_hwrng_register(&pdev->dev, &priv->rng);
+ if (ret) {
dev_err(&pdev->dev, "failed to register rng device: %d\n",
- error);
- return error;
+ ret);
+ return ret;
}
dev_info(&pdev->dev, "registered RNG driver\n");
--
1.9.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
end of thread, other threads:[~2015-05-04 9:58 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2015-05-01 14:37 [PATCH] hw_random: bcm63xx-rng: fix bugs introduced in commit 6229c16060fee9a015bf476f21e40c6f08609d6e Álvaro Fernández Rojas
2015-05-01 17:27 ` Florian Fainelli
2015-05-02 10:08 ` [PATCH v2] hw_random: bcm63xx-rng: Fix driver compilation Álvaro Fernández Rojas
2015-05-04 9:57 ` Herbert Xu
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox