From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751470AbbEASZt (ORCPT ); Fri, 1 May 2015 14:25:49 -0400 Received: from mail-pa0-f45.google.com ([209.85.220.45]:34693 "EHLO mail-pa0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751109AbbEASZs (ORCPT ); Fri, 1 May 2015 14:25:48 -0400 Message-ID: <5543C529.4080203@labbott.name> Date: Fri, 01 May 2015 11:25:45 -0700 From: Laura Abbott User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.10; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Hillf Danton CC: "'Russell King'" , linux-kernel , linux@arm.linux.org.uk Subject: Re: [patch] ARM: fix module-bound check in setting page attributes References: <042801d066b3$0ca78a30$25f69e90$@alibaba-inc.com> In-Reply-To: <042801d066b3$0ca78a30$25f69e90$@alibaba-inc.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 3/24/15 9:20 PM, Hillf Danton wrote: > It was introduced in commit f2ca09f381a59 > (ARM: 8311/1: Don't use is_module_addr in setting page attributes) > > We have no need to check start twice, but see if end is also in range. > > Signed-off-by: Hillf Danton > --- > > --- a/arch/arm/mm/pageattr.c Wed Mar 25 11:55:13 2015 > +++ b/arch/arm/mm/pageattr.c Wed Mar 25 11:57:31 2015 > @@ -52,7 +52,7 @@ static int change_memory_common(unsigned > if (start < MODULES_VADDR || start >= MODULES_END) > return -EINVAL; > > - if (end < MODULES_VADDR || start >= MODULES_END) > + if (end < MODULES_VADDR || end >= MODULES_END) > return -EINVAL; > > data.set_mask = set_mask; > -- > > Sorry for the delay, that e-mail address is being phased out. Please remember to Cc linux-arm-kernel when sending anything in arch/arm. If this hasn't been picked up, please resend with linux-arm-kernel Cc'ed and you can add Acked-by: Laura Abbott