Re: [PATCH v2 0/9] x86: remove cpu_**_mask() functions

Ingo Molnar
2015-05-04T11:22:59Z

* Bartosz Golaszewski <bgolaszewski@baylibre.com> wrote:

> Two functions defined in asm/smp.h: cpu_sibling_mask() and cpu_core_mask(),
> have the same functionality as macros defined in linux/topology.h:
> topology_thread_cpumask() and topology_core_cpumask() respectively.
>
> They are not documented and are architecture specific. Also: different
> naming for the same functionality (in case of cpu_sibling_mask() and
> topology_thread_cpumask()) is a bit misleading.
>
> This series makes all the callers switch to using the topology.h macros
> and removes their smp.h counterparts. While we're at it: rename
> topology_thread_cpumask() to topology_sibling_cpumask() to be
> consistent with the term used in the scheduler.
>
> The same duplication exists on powerpc.
>
> NOTE: patch 2/9 had been already submitted separately but didn't
> receive any attention, so I'm attaching it to this series.
>
> v2:
> - renamed topology_thread_cpumask() to topology_sibling_cpumask()
> - updated Documentation/cputopology.txt
>
> v1:
> https://lkml.org/lkml/2015/4/30/188
>
> Bartosz Golaszewski (9):
> topology: rename topology_thread_cpumask()
> Documentation: update cputopology.txt
> coretemp: replace cpu_sibling_mask() with topology_sibling_cpumask()
> powernow-k8: replace cpu_core_mask() with topology_core_cpumask()
> p4-clockmod: replace cpu_sibling_mask() with topology_sibling_cpumask()
> acpi-cpufreq: replace cpu_**_mask() with topology_**_cpumask()
> speedstep-ich: replace cpu_sibling_mask() with topology_sibling_cpumask()
> x86: replace cpu_**_mask() with topology_**_cpumask()
> x86: remove cpu_sibling_mask() and cpu_core_mask()

Acked-by: Ingo Molnar <mingo@kernel.org>

Thanks,

Ingo