From: "H. Peter Anvin" <hpa@zytor.com>
To: Richard Henderson <rth@redhat.com>,
Peter Zijlstra <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Vladimir Makarov <vmakarov@redhat.com>,
Jakub Jelinek <jakub@redhat.com>, Ingo Molnar <mingo@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Borislav Petkov <bp@alien8.de>,
"gcc@gcc.gnu.org" <gcc@gcc.gnu.org>
Subject: Re: [RFC] Design for flag bit outputs from asms
Date: Mon, 04 May 2015 13:14:03 -0700 [thread overview]
Message-ID: <5547D30B.2020507@zytor.com> (raw)
In-Reply-To: <5547C992.9000703@redhat.com>
On 05/04/2015 12:33 PM, Richard Henderson wrote:
>
> (0) The C level output variable should be an integral type, from bool on up.
>
> The flags are a scarse resource, easily clobbered. We cannot allow user code
> to keep data in the flags. While x86 does have lahf/sahf, they don't exactly
> perform well. And other targets like arm don't even have that bad option.
>
> Therefore, the language level semantics are that the output is a boolean store
> into the variable with a condition specified by a magic constraint.
>
> That said, just like the compiler should be able to optimize
>
> void bar(int y)
> {
> int x = (y <= 0);
> if (x) foo();
> }
>
> such that we only use a single compare against y, the expectation is that
> within a similarly constrained context the compiler will not require two tests
> for these boolean outputs.
>
> Therefore:
>
> (1) Each target defines a set of constraint strings,
>
> E.g. for x86, wherein we're almost out of constraint letters,
>
> ja aux carry flag
> jc carry flag
> jo overflow flag
> jp parity flag
> js sign flag
> jz zero flag
>
I would argue that for x86 what you actually want is to model the
*conditions* that are available on the flags, not the flags themselves.
There are 16 such conditions, 8 if we discard the inversions.
It is notable that the auxiliary carry flag has no Jcc/SETcc/CMOVcc
instructions; it is only ever consumed by the DAA/DAS instructions which
makes it pointless to try to model it in a compiler any more than, say, IF.
> (2) A new target hook post-processes the asm_insn, looking for the
> new constraint strings. The hook expands the condition prescribed
> by the string, adjusting the asm_insn as required.
>
> E.g.
>
> bool x, y, z;
> asm ("xyzzy" : "=jc"(x), "=jp"(y), "=jo"(z) : : );
Other than that, this is exactly what would be wonderful to see.
-hpa
next prev parent reply other threads:[~2015-05-04 20:15 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-01 15:16 [PATCH] x86: Optimize variable_test_bit() Peter Zijlstra
2015-05-01 16:03 ` Linus Torvalds
2015-05-01 16:16 ` Peter Zijlstra
2015-05-01 16:29 ` Peter Zijlstra
2015-05-01 16:18 ` Peter Zijlstra
2015-05-01 16:33 ` Jakub Jelinek
2015-05-01 16:45 ` Linus Torvalds
2015-05-01 16:46 ` Peter Zijlstra
2015-05-01 17:17 ` Ingo Molnar
2015-05-01 19:02 ` Vladimir Makarov
2015-05-01 20:49 ` Linus Torvalds
2015-05-01 22:22 ` Vladimir Makarov
2015-05-02 12:39 ` Peter Zijlstra
2015-05-04 15:37 ` Richard Henderson
2015-05-04 19:33 ` [RFC] Design for flag bit outputs from asms Richard Henderson
2015-05-04 20:14 ` H. Peter Anvin [this message]
2015-05-04 20:27 ` H. Peter Anvin
2015-05-04 20:33 ` Richard Henderson
2015-05-04 20:45 ` Linus Torvalds
2015-05-04 20:57 ` Richard Henderson
2015-05-04 21:23 ` H. Peter Anvin
2015-05-04 20:35 ` Linus Torvalds
2015-05-04 20:42 ` H. Peter Anvin
2015-05-05 9:01 ` Gabriel Paubert
2015-05-05 13:50 ` Segher Boessenkool
2015-05-05 15:37 ` Linus Torvalds
2015-05-05 16:10 ` Segher Boessenkool
2015-05-02 12:43 ` [PATCH] x86: Optimize variable_test_bit() Peter Zijlstra
2015-05-04 18:07 ` Vladimir Makarov
2015-05-04 20:14 ` H. Peter Anvin
2015-05-04 13:42 ` Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5547D30B.2020507@zytor.com \
--to=hpa@zytor.com \
--cc=bp@alien8.de \
--cc=gcc@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
--cc=rth@redhat.com \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
--cc=vmakarov@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).