From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1752378AbbEDUeo (ORCPT <rfc822;w@1wt.eu>);
	Mon, 4 May 2015 16:34:44 -0400
Received: from terminus.zytor.com ([198.137.202.10]:40812 "EHLO mail.zytor.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1752271AbbEDUe3 (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
	Mon, 4 May 2015 16:34:29 -0400
Message-ID: <5547D7B1.8070703@zytor.com>
Date: Mon, 04 May 2015 13:33:53 -0700
From: "H. Peter Anvin" <hpa@zytor.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.5.0
MIME-Version: 1.0
To: Josh Poimboeuf <jpoimboe@redhat.com>, Thomas Gleixner <tglx@linutronix.de>,
        Ingo Molnar <mingo@redhat.com>
CC: Michal Marek <mmarek@suse.cz>, Peter Zijlstra <peterz@infradead.org>,
        x86@kernel.org, live-patching@vger.kernel.org,
        linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 2/2] x86, stackvalidate: Add asm frame pointer setup
 macros
References: <cover.1430770553.git.jpoimboe@redhat.com> <df0e393755bfb792872d8e649bf802baff6b2407.1430770553.git.jpoimboe@redhat.com>
In-Reply-To: <df0e393755bfb792872d8e649bf802baff6b2407.1430770553.git.jpoimboe@redhat.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/04/2015 01:23 PM, Josh Poimboeuf wrote:
> +	__ASM_SIZE(push, _cfi) %_ASM_BP
> +	__ASM_SIZE(pop, _cfi) %_ASM_BP

This seems ridiculous.  push/pop only come in one size per
architecture(*).  Can we make it so that just push_cfi and pop_cfi do
the right things?

	-hpa

(*) Intentionally ignoring 16 bit here...