From: Robert Baldyga <r.baldyga@samsung.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: dan.j.williams@intel.com, vinod.koul@intel.com, lars@metafoo.de,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
m.szyprowski@samsung.com
Subject: Re: [PATCH 1/3] amba: add no_pm_pclk_management flag to amba_driver
Date: Tue, 05 May 2015 08:21:50 +0200 [thread overview]
Message-ID: <5548617E.5040208@samsung.com> (raw)
In-Reply-To: <20150416134158.GZ12732@n2100.arm.linux.org.uk>
On 04/16/2015 03:41 PM, Russell King - ARM Linux wrote:
> On Thu, Apr 16, 2015 at 03:39:12PM +0200, Robert Baldyga wrote:
>> This patch introduces no_pm_pclk_management flag in struct amba_driver.
>> It causes that pclk is not touched in pm_runtime callbacks. This allows
>> to manage clock in device driver independently of power domain management.
>
> NAK. We already have stuff in place to deal with the problem with
> DMA engine using runtime PM, which causes pclk management to fall
> back to the IRQ-safe clk_enable/clk_disable().
>
What kind of stuff do you mean? If we want to manage pclk independently
form runtime PM, we need to prevent AMBA driver from touching pclk.
Otherwise our clock management inside of dmaengine driver is ineffective
because pclk refcount is incremented by AMBA driver.
Thanks,
Robert Baldyga
next prev parent reply other threads:[~2015-05-05 6:22 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1429191554-24972-1-git-send-email-r.baldyga@samsung.com>
2015-04-16 13:39 ` [PATCH 1/3] amba: add no_pm_pclk_management flag to amba_driver Robert Baldyga
2015-04-16 13:41 ` Russell King - ARM Linux
2015-05-05 6:21 ` Robert Baldyga [this message]
2015-04-16 13:39 ` [PATCH 2/3] dmaengine: add dmaengine_pm_get()/dmaengine_pm_put() functions Robert Baldyga
2015-04-16 13:39 ` [PATCH 3/3] dmaengine: pl330: get rid of pm_runtime_irq_safe() Robert Baldyga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5548617E.5040208@samsung.com \
--to=r.baldyga@samsung.com \
--cc=dan.j.williams@intel.com \
--cc=dmaengine@vger.kernel.org \
--cc=lars@metafoo.de \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=m.szyprowski@samsung.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox