From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1756422AbbEEHRO (ORCPT <rfc822;w@1wt.eu>);
	Tue, 5 May 2015 03:17:14 -0400
Received: from mail-wi0-f169.google.com ([209.85.212.169]:33533 "EHLO
	mail-wi0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1756381AbbEEHRA (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 5 May 2015 03:17:00 -0400
Message-ID: <55486E68.7020304@linaro.org>
Date: Tue, 05 May 2015 08:16:56 +0100
From: Srinivas Kandagatla <srinivas.kandagatla@linaro.org>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0
MIME-Version: 1.0
To: Patrick Lai <plai@codeaurora.org>, Mark Brown <broonie@kernel.org>,
        Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Banajit Goswami <bgoswami@codeaurora.org>,
        Liam Girdwood <lgirdwood@gmail.com>, Jaroslav Kysela <perex@perex.cz>,
        Takashi Iwai <tiwai@suse.de>, devicetree@vger.kernel.org,
        linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org,
        linux-arm-msm@vger.kernel.org
Subject: Re: [RFC PATCH 08/14] ASoC: qcom: add dma channel control offset
 to variant data
References: <1430414148-10869-1-git-send-email-srinivas.kandagatla@linaro.org> <1430414252-11210-1-git-send-email-srinivas.kandagatla@linaro.org> <20150502235909.GD27804@kwestfie-linux.qualcomm.com>
In-Reply-To: <20150502235909.GD27804@kwestfie-linux.qualcomm.com>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org



On 03/05/15 00:59, Kenneth Westfield wrote:
> On Thu, Apr 30, 2015 at 06:17:32PM +0100, Srinivas Kandagatla wrote:
>> This patch adds ability to pass dma channel control bits start offset, which
>> differ in differnet qcom SOCs. On apq8016 dma channel control bits start
>> after an offset of 1.
>
> Alot of the SOCs have similar small differences in the LPASS register
> map.  For now, this is fine, but we will probably want to add some
> system of quirks to handle these differences; as more SOCs drivers
> are implemented.
>
Yes, I agree, only reason for adding it in to variant data could be that 
I was looking at drivers/mmc/host/mmmci.c file a lot :-)

--srini