From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756457AbbEEHRy (ORCPT ); Tue, 5 May 2015 03:17:54 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:38904 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965096AbbEEHRi (ORCPT ); Tue, 5 May 2015 03:17:38 -0400 Message-ID: <55486E8E.8010105@linaro.org> Date: Tue, 05 May 2015 08:17:34 +0100 From: Srinivas Kandagatla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: Patrick Lai , Mark Brown , Rob Herring , Pawel Moll , Ian Campbell , Kumar Gala , Banajit Goswami , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, alsa-devel@alsa-project.org, linux-arm-msm@vger.kernel.org Subject: Re: [RFC PATCH 07/14] ASoC: qcom: add no osr clk flag to lpass variant References: <1430414148-10869-1-git-send-email-srinivas.kandagatla@linaro.org> <1430414244-11168-1-git-send-email-srinivas.kandagatla@linaro.org> <20150502235800.GC27804@kwestfie-linux.qualcomm.com> In-Reply-To: <20150502235800.GC27804@kwestfie-linux.qualcomm.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 03/05/15 00:58, Kenneth Westfield wrote: > On Thu, Apr 30, 2015 at 06:17:24PM +0100, Srinivas Kandagatla wrote: >> Some LPASS integrations like on APQ8016 do not have OSR clk, so adding >> no osr clk bit would allow such integrations to use lpass driver. > > Going forward, as the code is generalized, perhaps having an enable flag > for each clock, rather than a flag that negates an existing clock? > Or checking that the clock pointer is NULL after probing would be the > indication? Mark also suggested the same thing, I will fix it in next version. --srini