From: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
To: Lee Jones <lee.jones@linaro.org>, Gwendal Grignou <gwendal@chromium.org>
Cc: Olof Johansson <olof@lixom.net>,
Doug Anderson <dianders@chromium.org>,
Bill Richardson <wfrichar@chromium.org>,
Simon Glass <sjg@google.com>,
Stephen Barber <smbarber@chromium.org>,
Filipe Brandenburger <filbranden@google.com>,
Todd Broch <tbroch@chromium.org>,
linux-samsung-soc@vger.kernel.org,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RESEND PATCH 1/8] mfd: cros ec: Remove parent field
Date: Tue, 05 May 2015 11:06:50 +0200 [thread overview]
Message-ID: <5548882A.50400@collabora.co.uk> (raw)
In-Reply-To: <20150429103734.GU9169@x1>
Hello Lee,
On 04/29/2015 12:37 PM, Lee Jones wrote:
> On Thu, 23 Apr 2015, Gwendal Grignou wrote:
>
>> Be consistent, use cros_ec instead of "cros ec" or "cros-ec".
>
> What is this in reference to?
>
I think Gwendal meant that I should be consistent in general and was not
referring to this patch particular.
>> Otherwise:
>>
>> Reviewed-by: Gwendal Grignou <gwendal@chromium.org>
>> Tested-by: Gwendal Grignou <gwendal@chromium.org>
>>
>> On Mon, Apr 6, 2015 at 9:14 AM, Javier Martinez Canillas
>> <javier.martinez@collabora.co.uk> wrote:
>> > From: Gwendal Grignou <gwendal@chromium.org>
>> >
>> > parent and dev were pointing to the same device structure.
>> > parent is unused, removed.
>> >
>> > Signed-off-by: Gwendal Grignou <gwendal@chromium.org>
>> > Reviewed-by: Stephen Barber <smbarber@chromium.org>
>> > Tested-by: Stephen Barber <smbarber@chromium.org>
>> > Reviewed-by: Puthikorn Voravootivat <puthik@chromium.org>
>> > Signed-off-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>> > ---
>> > drivers/mfd/cros_ec_i2c.c | 1 -
>> > drivers/mfd/cros_ec_spi.c | 1 -
>> > drivers/platform/chrome/cros_ec_lpc.c | 1 -
>> > include/linux/mfd/cros_ec.h | 2 --
>> > 4 files changed, 5 deletions(-)
>
> For when you re-submit:
>
> Acked-by: Lee Jones <lee.jones@linaro.org>
>
Thanks a lot for your ack.
Best regards,
Javier
next prev parent reply other threads:[~2015-05-05 9:07 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-04-06 16:14 [RESEND PATCH 0/8] cros_ec: Add multiple EC and protocol v3 support Javier Martinez Canillas
2015-04-06 16:14 ` [RESEND PATCH 1/8] mfd: cros ec: Remove parent field Javier Martinez Canillas
2015-04-23 20:15 ` Gwendal Grignou
2015-04-29 10:37 ` Lee Jones
2015-05-05 9:06 ` Javier Martinez Canillas [this message]
2015-05-05 10:54 ` Lee Jones
2015-05-09 1:38 ` Javier Martinez Canillas
2015-04-06 16:15 ` [RESEND PATCH 2/8] platform/chrome: cros_ec_lpc - Use existing function to check EC result Javier Martinez Canillas
2015-04-26 1:33 ` Gwendal Grignou
2015-04-06 16:15 ` [RESEND PATCH 3/8] mfd: cros_ec: Instantiate sub-devices from device tree Javier Martinez Canillas
2015-04-26 1:34 ` Gwendal Grignou
2015-04-29 10:39 ` Lee Jones
2015-05-05 9:21 ` Javier Martinez Canillas
2015-05-05 10:53 ` Lee Jones
2015-05-05 10:57 ` Javier Martinez Canillas
2015-04-06 16:15 ` [RESEND PATCH 4/8] mfd: cros_ec: Use a zero-length array for command data Javier Martinez Canillas
2015-04-16 9:45 ` Heiko Stübner
2015-04-16 9:55 ` Javier Martinez Canillas
2015-04-24 5:19 ` Gwendal Grignou
2015-05-05 15:53 ` Javier Martinez Canillas
2015-04-24 20:29 ` Gwendal Grignou
2015-05-05 15:57 ` Javier Martinez Canillas
2015-04-06 16:15 ` [RESEND PATCH 5/8] mfd: cros-ec: Support multiple EC in a system Javier Martinez Canillas
2015-04-23 23:54 ` Gwendal Grignou
2015-05-05 15:40 ` Javier Martinez Canillas
2015-04-06 16:15 ` [RESEND PATCH 6/8] mfd: cros_ec: rev cros_ec_commands.h Javier Martinez Canillas
2015-04-26 1:35 ` Gwendal Grignou
2015-04-29 10:45 ` Lee Jones
2015-04-06 16:15 ` [RESEND PATCH 7/8] mfd: cros_ec: add proto v3 skeleton Javier Martinez Canillas
2015-04-26 1:39 ` Gwendal Grignou
2015-05-05 15:59 ` Javier Martinez Canillas
2015-04-06 16:15 ` [RESEND PATCH 8/8] mfd: cros_ec: add bus-specific proto v3 code Javier Martinez Canillas
2015-04-26 1:39 ` Gwendal Grignou
2015-04-16 7:29 ` [RESEND PATCH 0/8] cros_ec: Add multiple EC and protocol v3 support Javier Martinez Canillas
2015-04-16 9:49 ` Heiko Stübner
2015-04-16 10:24 ` Javier Martinez Canillas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5548882A.50400@collabora.co.uk \
--to=javier.martinez@collabora.co.uk \
--cc=dianders@chromium.org \
--cc=filbranden@google.com \
--cc=gwendal@chromium.org \
--cc=lee.jones@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=olof@lixom.net \
--cc=sjg@google.com \
--cc=smbarber@chromium.org \
--cc=tbroch@chromium.org \
--cc=wfrichar@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox