From: Sudeep Holla <sudeep.holla@arm.com>
To: Hanjun Guo <hanjun.guo@linaro.org>
Cc: "Rafael J. Wysocki" <rjw@rjwysocki.net>,
Sudeep Holla <sudeep.holla@arm.com>,
Will Deacon <Will.Deacon@arm.com>,
Catalin Marinas <Catalin.Marinas@arm.com>,
Boris Ostrovsky <boris.ostrovsky@oracle.com>,
Stefano Stabellini <stefano.stabellini@eu.citrix.com>,
Lorenzo Pieralisi <Lorenzo.Pieralisi@arm.com>,
"linux-acpi@vger.kernel.org" <linux-acpi@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linaro-acpi@lists.linaro.org" <linaro-acpi@lists.linaro.org>
Subject: Re: [PATCH v2 3/7] ACPI / processor: Introduce invalid_logical_cpuid()
Date: Tue, 05 May 2015 12:15:13 +0100 [thread overview]
Message-ID: <5548A641.6050407@arm.com> (raw)
In-Reply-To: <1430793998-21631-4-git-send-email-hanjun.guo@linaro.org>
On 05/05/15 03:46, Hanjun Guo wrote:
> In ACPI processor drivers, we use direct comparisons of cpu logical
> id with -1 which are error prone in case logical cpuid is accidentally
> assinged an error code and prevents us from returning an error-encoding
> cpuid directly in some cases.
>
> So introduce invalid_logical_cpuid() to identify cpu with invalid
> logical cpu num, then it will be used to replace the direct comparisons
> with -1.
>
Ah, OK I see that this fixes the issue I raised in PATCH 1/7, so I think
you need to reorder this and 1/7 patch IMO.
Regards,
Sudeep
next prev parent reply other threads:[~2015-05-05 11:15 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-05 2:46 [PATCH v2 0/7] minor cleanups for ACPI processor driver Hanjun Guo
2015-05-05 2:46 ` [PATCH v2 1/7] ACPI / processor: remove cpu_index in acpi_processor_get_info() Hanjun Guo
2015-05-05 11:08 ` Sudeep Holla
2015-05-05 2:46 ` [PATCH v2 2/7] ACPI / processor: remove phys_id " Hanjun Guo
2015-05-05 2:46 ` [PATCH v2 3/7] ACPI / processor: Introduce invalid_logical_cpuid() Hanjun Guo
2015-05-05 11:15 ` Sudeep Holla [this message]
2015-05-05 12:04 ` Rafael J. Wysocki
2015-05-05 13:15 ` Hanjun Guo
2015-05-05 12:01 ` Rafael J. Wysocki
2015-05-05 13:15 ` Hanjun Guo
2015-05-05 15:12 ` Boris Ostrovsky
2015-05-05 2:46 ` [PATCH v2 4/7] Xen / ACPI / processor: use invalid_logical_cpuid() Hanjun Guo
2015-05-05 2:46 ` [PATCH v2 5/7] Xen / ACPI / processor: Remove unneeded NULL check in xen_acpi_processor_enable() Hanjun Guo
2015-05-05 10:29 ` Stefano Stabellini
2015-05-09 22:06 ` Konrad Rzeszutek Wilk
2015-05-05 2:46 ` [PATCH v2 6/7] ACPI / processor: return specific error instead of -1 Hanjun Guo
2015-05-05 2:46 ` [PATCH v2 7/7] ACPI / processor: Introduce invalid_phys_cpuid() Hanjun Guo
2015-05-05 11:25 ` Sudeep Holla
2015-05-05 13:14 ` Hanjun Guo
2015-05-11 16:35 ` Lorenzo Pieralisi
2015-05-13 6:39 ` Hanjun Guo
2015-05-06 4:11 ` Hanjun Guo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5548A641.6050407@arm.com \
--to=sudeep.holla@arm.com \
--cc=Catalin.Marinas@arm.com \
--cc=Lorenzo.Pieralisi@arm.com \
--cc=Will.Deacon@arm.com \
--cc=boris.ostrovsky@oracle.com \
--cc=hanjun.guo@linaro.org \
--cc=linaro-acpi@lists.linaro.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=rjw@rjwysocki.net \
--cc=stefano.stabellini@eu.citrix.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox