From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1031049AbbEELPY (ORCPT ); Tue, 5 May 2015 07:15:24 -0400 Received: from foss.arm.com ([217.140.101.70]:44474 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752181AbbEELPR (ORCPT ); Tue, 5 May 2015 07:15:17 -0400 Message-ID: <5548A641.6050407@arm.com> Date: Tue, 05 May 2015 12:15:13 +0100 From: Sudeep Holla User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Hanjun Guo CC: "Rafael J. Wysocki" , Sudeep Holla , Will Deacon , Catalin Marinas , Boris Ostrovsky , Stefano Stabellini , Lorenzo Pieralisi , "linux-acpi@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "linaro-acpi@lists.linaro.org" Subject: Re: [PATCH v2 3/7] ACPI / processor: Introduce invalid_logical_cpuid() References: <1430793998-21631-1-git-send-email-hanjun.guo@linaro.org> <1430793998-21631-4-git-send-email-hanjun.guo@linaro.org> In-Reply-To: <1430793998-21631-4-git-send-email-hanjun.guo@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 05/05/15 03:46, Hanjun Guo wrote: > In ACPI processor drivers, we use direct comparisons of cpu logical > id with -1 which are error prone in case logical cpuid is accidentally > assinged an error code and prevents us from returning an error-encoding > cpuid directly in some cases. > > So introduce invalid_logical_cpuid() to identify cpu with invalid > logical cpu num, then it will be used to replace the direct comparisons > with -1. > Ah, OK I see that this fixes the issue I raised in PATCH 1/7, so I think you need to reorder this and 1/7 patch IMO. Regards, Sudeep