From: "Bryan O'Donoghue" <pure.logic@nexus-software.ie>
To: Paul Bolle <pebolle@tiscali.nl>
Cc: tglx@linutronix.de, mingo@redhat.com, hpa@zytor.com,
x86@kernel.org, dvhart@infradead.org, andy.schevchenko@gmail.com,
boon.leong.ong@intel.com, linux-kernel@vger.kernel.org,
platform-driver-x86@vger.kernel.org, derek.browne@intel.com,
josef.ahmad@intel.com, erik.nyquist@intel.com
Subject: Re: [PATCH 1/2] x86/quark: Add Quark embedded SRAM support
Date: Tue, 05 May 2015 06:03:05 -0700 [thread overview]
Message-ID: <5548BF89.3060705@nexus-software.ie> (raw)
In-Reply-To: <1430815487.3843.24.camel@x220>
On 05/05/15 01:44, Paul Bolle wrote:
> On Mon, 2015-05-04 at 03:17 +0100, Bryan O'Donoghue wrote:
>> --- a/arch/x86/platform/intel-quark/Makefile
>> +++ b/arch/x86/platform/intel-quark/Makefile
>
>> obj-$(CONFIG_INTEL_IMR) += imr.o
>
> (Your change to drivers/platform/x86/Kconfig now makes it possible that
> imr.o will be part of a module. More on that below.)
>
>> +obj-$(CONFIG_INTEL_ESRAM) += esram.o
>
> INTEL_ESRAM is a bool Kconfig symbol, so esram.o will never be part of a
> module, right?
Nope - this is kak that is hanging around in my git repo for no good
reason. No intention to make IMRs modules (and in fact everything would
break if they were).
Thanks - no idea how that crept in :)
> Was your intention perhaps to make this a tristate symbol?
No I think I was making esram tristate for test purposes - edited the
wrong line - and then didn't scrub it before the patchseries :(
Cheers !
next prev parent reply other threads:[~2015-05-05 13:03 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-05-04 2:17 [PATCH 0/2] x86/quark: Add eSRAM driver and test code Bryan O'Donoghue
2015-05-04 2:17 ` [PATCH 1/2] x86/quark: Add Quark embedded SRAM support Bryan O'Donoghue
2015-05-04 15:00 ` Thomas Gleixner
2015-05-05 13:48 ` Bryan O'Donoghue
2015-05-05 20:07 ` Darren Hart
2015-05-05 22:19 ` H. Peter Anvin
2015-05-05 8:44 ` Paul Bolle
2015-05-05 13:03 ` Bryan O'Donoghue [this message]
2015-05-06 9:58 ` Ingo Molnar
2015-05-06 15:46 ` Bryan O'Donoghue
2015-05-04 2:17 ` [PATCH 2/2] x86/quark: Add Quark embedded SRAM self-test Bryan O'Donoghue
2015-05-05 8:34 ` Paul Bolle
2015-05-06 10:02 ` Ingo Molnar
2015-05-06 14:27 ` Bryan O'Donoghue
2015-05-06 10:08 ` Ingo Molnar
2015-05-06 9:52 ` [PATCH 0/2] x86/quark: Add eSRAM driver and test code Ingo Molnar
2015-05-06 15:27 ` Bryan O'Donoghue
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5548BF89.3060705@nexus-software.ie \
--to=pure.logic@nexus-software.ie \
--cc=andy.schevchenko@gmail.com \
--cc=boon.leong.ong@intel.com \
--cc=derek.browne@intel.com \
--cc=dvhart@infradead.org \
--cc=erik.nyquist@intel.com \
--cc=hpa@zytor.com \
--cc=josef.ahmad@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pebolle@tiscali.nl \
--cc=platform-driver-x86@vger.kernel.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox