From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S2993536AbbEEQF7 (ORCPT <rfc822;w@1wt.eu>);
	Tue, 5 May 2015 12:05:59 -0400
Received: from out2-smtp.messagingengine.com ([66.111.4.26]:42394 "EHLO
	out2-smtp.messagingengine.com" rhost-flags-OK-OK-OK-OK)
	by vger.kernel.org with ESMTP id S2993135AbbEEOQc (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 5 May 2015 10:16:32 -0400
X-Sasl-enc: aQgB5W0kh3YvOcRg9lsJbEvaGrMruTZ5PYaP9hS+ReZR 1430835391
Message-ID: <5548D0BD.3080602@iki.fi>
Date: Tue, 05 May 2015 17:16:29 +0300
From: Pekka Enberg <penberg@iki.fi>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.6.0
MIME-Version: 1.0
To: Arnaldo Carvalho de Melo <acme@kernel.org>,
        Namhyung Kim <namhyung@kernel.org>
CC: Ingo Molnar <mingo@kernel.org>, Peter Zijlstra <a.p.zijlstra@chello.nl>,
        Jiri Olsa <jolsa@redhat.com>, LKML <linux-kernel@vger.kernel.org>,
        David Ahern <dsahern@gmail.com>, Joonsoo Kim <js1304@gmail.com>,
        Minchan Kim <minchan@kernel.org>, Pekka Enberg <penberg@kernel.org>,
        linux-mm@kvack.org
Subject: Re: [PATCH v2] perf kmem: Show warning when trying to run stat without
 record
References: <20150504161539.GG10475@kernel.org> <1430787492-6893-1-git-send-email-namhyung@kernel.org> <20150505140706.GJ10475@kernel.org>
In-Reply-To: <20150505140706.GJ10475@kernel.org>
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On 05/05/2015 05:07 PM, Arnaldo Carvalho de Melo wrote:
> Em Tue, May 05, 2015 at 09:58:12AM +0900, Namhyung Kim escreveu:
>> Sometimes one can mistakenly run perf kmem stat without perf kmem
>> record before or different configuration like recoding --slab and stat
>> --page.  Show a warning message like below to inform user:
>>
>>    # perf kmem stat --page --caller
>>    Not found page events.  Have you run 'perf kmem record --page' before?
>>
>> Acked-by: Pekka Enberg <penberg@kernel.org>
>> Signed-off-by: Namhyung Kim <namhyung@kernel.org>
> Thanks, applied.
>
> I just found the messages a bit odd souding, perhaps:
>
>     # perf kmem stat --page --caller
>     No page allocation events found.  Have you run 'perf kmem record --page'?
>
> Pekka?

Sure, that sounds less confusing.

- Pekka