Re: [PATCH] MODSIGN: Change default key details [ver #2]

[Michal Marek <mmarek@suse.cz>]

On 2015-05-04 20:45, Linus Torvalds wrote:
> On Sun, May 3, 2015 at 6:45 PM, Linus Torvalds
> <torvalds@linux-foundation.org> wrote:
>>
>> I'd much rather see "x509.genkey" be generated with a move-if-changed
>> pattern, so that it only changes if (a) it didn't exist before or (b)
>> it actually has new content.
> 
> Hmm. Something like the attached, to make the .x509.list file be
> properly generated?
> 
> That still leaves the problem that the X509_CERTIFICATES variable
> itself seems to be badly defined, in that it ends up randomly having
> the "./" in front of the filename due to confusion between
> "signing_key.x509" being both in
> 
>    X509_CERTIFICATES-y := $(wildcard *.x509) $(wildcard $(srctree)/*.x509)
> 
> (when that .x509 file was pre-existing), and
> 
>    X509_CERTIFICATES-$(CONFIG_MODULE_SIG) += $(objtree)/signing_key.x509
> 
> where I think that "$(objtree)/" comes in.

This will be fixed once https://lkml.org/lkml/2015/2/20/546 is merged
(the two patches are independent of each other).

Michal